[pulseaudio-tickets] [PulseAudio] #706: [PATCH] Automatically switch to new devices
PulseAudio
trac-noreply at tango.0pointer.de
Tue Nov 3 14:16:48 PST 2009
#706: [PATCH] Automatically switch to new devices
--------------------------+-------------------------------------------------
Reporter: mterry | Owner: lennart
Type: enhancement | Status: new
Milestone: | Component: daemon
Resolution: | Keywords:
--------------------------+-------------------------------------------------
Comment(by lennart):
I guess the idea in general does make sense: if a user plugs in a new
device this could indeed be seen as an indication that he actually wants
to use it... ;-)
Some comments on the patch:
I don't see why this module should hook into
PA_CORE_HOOK_SINK_INPUT_MOVE_FAIL.
Also, this module should make sure not to touch streams/device that have
the 'intended roles' property set. Handling of that should be left to
module-intended-roles. Also, if the "save_device" flag is set for a stream
it should be left alone, since that is a sign that the user manually moved
the stream to the device, and we shouldn't fiddle with that.
Hmm, the find_evacuation_sink() call doesn't make too much sense here,
does it? I mean, that looks a bit too much like a 1:1 copy from m-rescue-
streams. But that module looks into devices that go away and then searches
for a replacement sink fo the stream, this module here looks into sinks
being added, and they themselves should be the destination where to move
streams to.
--
Ticket URL: <http://pulseaudio.org/ticket/706#comment:2>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server
More information about the pulseaudio-bugs
mailing list