[pulseaudio-tickets] [PulseAudio] #679: Use of O_CLOEXEC is not BSD friendly

[PulseAudio]

#679: Use of O_CLOEXEC is not BSD friendly
---------------------+------------------------------------------------------
  Reporter:  xtophe  |       Owner:  lennart
      Type:  defect  |      Status:  new    
 Milestone:          |   Component:  core   
Resolution:          |    Keywords:         
---------------------+------------------------------------------------------

Comment(by lennart):

 Replying to [comment:5 matthijs]:
 > This does not affect just BSD, also older Linux systems (< 2.6.23) break
 on this (I've come across this bug when compiling Pulse for OpenWRT).

 I am not too concerned about older Linux kernels. Due to the general
 buginess of the various audio drivers in the older Linux kernels, running
 PA on them is not a lot of fun anyway (unless you set tsched=0).

 > As for the patch, it looks like an elegant solution to solve the
 problem. If there is such a pa_make_fd_cloexec function, is there any
 reason it's not used in
 [http://git.0pointer.de/?p=pulseaudio.git;a=blob;f=src/pulsecore/database-
 tdb.c;h=b79d2837dc40110cb82101700d4619dfdf6bae65;hb=HEAD#l79 src/pulsecore
 /database-tdb]? There, the O_CLOEXEC flag is just left out if it's not
 supported.

 Generally we should use O_CLOEXEC everywhere insead of depending on
 pa_make_fd_cloexec(), since it fixes a couple of races.

-- 
Ticket URL: <http://pulseaudio.org/ticket/679#comment:6>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server