[pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

[PulseAudio]

#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
---------------------+------------------------------------------------------
  Reporter:  mgrela  |       Owner:  lennart     
      Type:  defect  |      Status:  new         
 Milestone:          |   Component:  module-x11-*
Resolution:          |    Keywords:              
---------------------+------------------------------------------------------

Old description:

> Hi,
>
> I recently tried to build pulseaudio with most recent xcb-util from git
> on my Gentoo box. It failed with the following error:
>
>   CC     libpulsecommon_0.9.22_la-x11prop.lo
> pulsecore/x11prop.c: In function 'pa_x11_set_prop':
> pulsecore/x11prop.c:60:9: warning: implicit declaration of function
> 'xcb_atom_get' [-Wimplicit-function-declaration]
> pulsecore/x11prop.c:61:70: error: 'STRING' undeclared (first use in this
> function)
> pulsecore/x11prop.c:61:70: note: each undeclared identifier is reported
> only once for each function it appears in
> pulsecore/x11prop.c: In function 'pa_x11_get_prop':
> pulsecore/x11prop.c:104:53: error: 'STRING' undeclared (first use in this
> function)
> make[3]: *** [libpulsecommon_0.9.22_la-x11prop.lo] Error 1
>
> I've made a patch to change the call to the missing xcb_atom_get to
> something that xcb can manage. I also updated the STRING constants as
> they were obsoleted some time ago. I'm attaching the patch in the hope
> you will find it useful and include it in the main code.
>
> Best regards,
> Maciej Grela

New description:

 Hi,

 I recently tried to build pulseaudio with most recent xcb-util from git on
 my Gentoo box. It failed with the following error:

 {{{
   CC     libpulsecommon_0.9.22_la-x11prop.lo
 pulsecore/x11prop.c: In function 'pa_x11_set_prop':
 pulsecore/x11prop.c:60:9: warning: implicit declaration of function
 'xcb_atom_get' [-Wimplicit-function-declaration]
 pulsecore/x11prop.c:61:70: error: 'STRING' undeclared (first use in this
 function)
 pulsecore/x11prop.c:61:70: note: each undeclared identifier is reported
 only once for each function it appears in
 pulsecore/x11prop.c: In function 'pa_x11_get_prop':
 pulsecore/x11prop.c:104:53: error: 'STRING' undeclared (first use in this
 function)
 make[3]: *** [libpulsecommon_0.9.22_la-x11prop.lo] Error 1
 }}}

 I've made a patch to change the call to the missing xcb_atom_get to
 something that xcb can manage. I also updated the STRING constants as they
 were obsoleted some time ago. I'm attaching the patch in the hope you will
 find it useful and include it in the main code.

 Best regards,
 Maciej Grela

--

Comment(by coling):

 Thanks for the patch.

 Can I ask a few questions about the code (I did the conversion to XCB but
 am by no means an XCB expert!):
  * The use of the word "intern" in the API names makes me think these are
 not meant to be access via external apps and this is just a short term fix
 for a larger problem? Am I reading too much into the names and this is
 actually named this way for other reasons?
  * Does this still compile with older XCB? If not then we need to do some
 #if magic or similar as not supporting older XCB is not an option at this
 stage.

 Cheers for any info you can provide :)

-- 
Ticket URL: <http://pulseaudio.org/ticket/927#comment:3>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server