[pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

[PulseAudio]

#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
---------------------+------------------------------------------------------
  Reporter:  mgrela  |       Owner:  lennart     
      Type:  defect  |      Status:  reopened    
 Milestone:  1.0     |   Component:  module-x11-*
Resolution:          |    Keywords:              
---------------------+------------------------------------------------------
Changes (by arnau):

 * cc: arnau at debian.org (added)
  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Hello,

 I'm reopening this bug as the issue is not completely fixed, hope that's
 ok.

 The patch above fixes building with xcb-util >= 0.3.8, but the reply is
 never checked (possible SIGSEGV if the reply is NULL) nor freed (memory
 leak at each call of the functions). Indeed, xcb_atom_get() used to do
 that.

 Also, xcb-atom was only meaningful for xcb_atom_get() and STRING, so it
 could be removed now and the build should check for xcb >= 1.6 as
 XCB_ATOM_STRING was introduced from this version.

 I have added a patch addressing these issues. Could you please consider
 applying it? Thanks!

 Cheers,
 Arnaud Fontaine

-- 
Ticket URL: <http://pulseaudio.org/ticket/927#comment:7>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server