[pulseaudio-tickets] [PulseAudio] #934: downmix to mono makes audio cliffing.

[PulseAudio]

#934: downmix to mono makes audio cliffing.
-----------------------+----------------------------------------------------
  Reporter:  kwanghui  |       Owner:  Ford_Prefect
      Type:  defect    |      Status:  assigned    
 Milestone:            |   Component:  daemon      
Resolution:            |    Keywords:  remap       
-----------------------+----------------------------------------------------
Changes (by Ford_Prefect):

  * owner:  lennart => Ford_Prefect
  * status:  new => assigned
  * milestone:  1.0 =>


Comment:

 I'd go with a simpler patch like this one which would force us to use the
 rest of the resampling code. That said, I think we should defer this to
 post-1.0.

 {{{
 diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c
 index b5c1611..d2612e4 100644
 --- a/src/pulsecore/resampler.c
 +++ b/src/pulsecore/resampler.c
 @@ -699,7 +699,7 @@ static void calc_map_table(pa_resampler *r) {
               * best to pass it to L+R.
               */

 -            if (a == b || a == PA_CHANNEL_POSITION_MONO || b ==
 PA_CHANNEL_POSITION_MONO) {
 +            if (a == b || a == PA_CHANNEL_POSITION_MONO) {
                  m->map_table_f[oc][ic] = 1.0;

                  oc_connected = TRUE;
 }}}

-- 
Ticket URL: <http://pulseaudio.org/ticket/934#comment:3>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server