[pulseaudio-tickets] [Bug 42715] New: Does not compile on GNU/Hurd

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42715

             Bug #: 42715
           Summary: Does not compile on GNU/Hurd
    Classification: Unclassified
           Product: PulseAudio
           Version: unspecified
          Platform: All
        OS/Version: other
            Status: NEW
          Severity: enhancement
          Priority: medium
         Component: misc
        AssignedTo: pulseaudio-bugs at lists.freedesktop.org
        ReportedBy: toscano.pino at tiscali.it
         QAContact: pulseaudio-bugs at lists.freedesktop.org
                CC: lennart at poettering.net


Created attachment 53298
  --> https://bugs.freedesktop.org/attachment.cgi?id=53298
Hurd fixes for PulseAudio 1.1

PulseAudio 1.1 does not compile on GNU/Hurd yet. Below there is a list of the
various problems (which could be solved in PA upstream) and eventual solutions
found:

* src/pulsecore/mutex-posix.c: runtime assert() failing
pa_mutex_new asserts on setting the PRIO_INHERIT on the mutex attributes, but
this is not implemented on Hurd yet; although, given few lines below the code
gracefully handles such case, then make that pthread_mutexattr_setprotocol() do
that as well

* src/modules/rtp/rtp.c: SO_TIMESTAMP
most probably the right type to check should be SCM_TIMESTAMP, like other types
available for cmsg_type (eg SCM_RIGHTS)

* src/modules/rtp/module-rtp-recv.c: SO_TIMESTAMP
Hurd does not have this non-POSIX feature yet, so directly fail if SO_TIMESTAMP
is not provided in the current platform

* src/modules/module-pipe-source.c: PIPE_BUF
make use of the available pa_pipe_buf() for the job, hopefully with the correct
fd

* src/utils/pacmd.c: PIPE_BUF
here the two 'ibuf' and 'obuf' are dynamically allocated with the minimum size
of all the pipe_buf for the fd's they are used as buffer when reading from and
writing to

Maybe not all the changes are clean or wanted in PA upstream, but having a
review for them would be nice anyway (so we can keep them in Debian GNU/Hurd).

(This has been originally reported as http://pulseaudio.org/ticket/817, but
that got no feedback in 18 months...)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.