[pulseaudio-tickets] [Bug 42925] New: DEFAULT_ECHO_CANCELLER webrtc makes no sense if not compiled in

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42925

             Bug #: 42925
           Summary: DEFAULT_ECHO_CANCELLER webrtc makes no sense if not
                    compiled in
    Classification: Unclassified
           Product: PulseAudio
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: modules
        AssignedTo: pulseaudio-bugs at lists.freedesktop.org
        ReportedBy: pmeerw at pmeerw.net
         QAContact: pulseaudio-bugs at lists.freedesktop.org
                CC: lennart at poettering.net


module-echo-cancel.c has

#define DEFAULT_ECHO_CANCELLER "webrtc"

which leads to 

E: [lt-pulseaudio] module-echo-cancel.c: Invalid echo canceller implementation

when loading module-echo-cancel if webrtc is not compiled in and the AEC
implementation is not specified

I suggest

#ifdef HAVE_WEBRTC
#define DEFAULT_ECHO_CANCELLER "webrtc"
#else
#define DEFAULT_ECHO_CANCELLER "speed"
#endif

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.