[pulseaudio-tickets] [Bug 42942] memory leak in pa_threaded_mainloop_free

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42942

--- Comment #1 from Peter Meerwald <pmeerw at pmeerw.net> 2011-11-15 02:47:44 PST ---
rerunning with
VALGRIND=1 valgrind --leak-check=full --show-reachable=yes ./pa-test2
and the leak went away...

seriously, this is garbage and undocumented (?) until you end up looking at
#define PA_STATIC_TLS_DECLARE(name, free_cb) 
to find out that the destructor 

    static void name##_tls_destructor(void) {                           \
        static void (*_free_cb)(void*) = free_cb;                       \
        if (!pa_in_valgrind())                                          \
            return;                                                     \

just returns if the environment variable (!!!) VALGRIND is not set

why to check for valgrind/memcheck.h in configure.ac then?

I strongly suggest to drop the pa_in_valgrind() checks in various destructors
(thread/flist) altogether 

if I call something_free() I expect that something is actually freed, and NOT
that someone is supersmart about it (for what reason anyway?)

annoyed...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.