[pulseaudio-tickets] [Bug 41538] Solaris compile fixes for PulseAudio 1.0

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41538

--- Comment #2 from Brian Cameron <brian.cameron at oracle.com> 2011-10-10 08:40:58 PDT ---

Your question is about this hunk:

--- pulseaudio-0.9.22/src/pulsecore/socket-server.c-orig    2011-06-09
16:43:59.167250309 -0500
+++ pulseaudio-0.9.22/src/pulsecore/socket-server.c    2011-06-09
16:59:12.482110908 -0500
@@ -44,7 +44,12 @@
 #endif

 #ifdef HAVE_LIBWRAP
+#ifdef __sun
+#include <syslog.h>
+int allow_severity = LOG_INFO;
+int deny_severity = LOG_WARNING;
+#endif
 #include <tcpd.h>
 #endif

---

On Linux, the libwrap library includes the allow_severity and deny_severity
symbols.  You can look at it and check.  On Solaris, these interfaces are
referenced by the library but the symbols are not in the library.  The
expectation is that on Solaris, the client program defines them.  Since Solaris
handles this differently, the code is wrapped in "#ifdef __sun".

You will notice that other programs that use libwrap, such as GDM (see
gdm/daemon/gdm-xdmcp-display-factory.c) make use of the same "#ifdef __sun"
code.

I do not think this particular #ifdef clutters the code overmuch, and it does
make the code buildable on Solaris, so it would be nice if it could go
upstream.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.