[pulseaudio-tickets] [Bug 41822] PulseAudio LICENSE file is wrong or misleading about GPL/LGPL

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41822

--- Comment #1 from Brian Cameron <brian.cameron at oracle.com> 2011-10-17 16:15:45 PDT ---

Reviewing the LICENSE file and the licenses in the code a bit more closely, I
notice the following issues

1) I think the LICENSE file could be more clear that libsamplerate is an 
   optional dependency and that the license of libpulsecore is affected if 
   you build with it.  The way it reads, it sounds like libpulsecore is GPL
   regardless.

2) I notice that these files are under the GPL:

   - pulseaudio-1.0/src/modules/bluetooth/proximity-helper.c
   - pulseaudio-1.0/src/modules/bluetooth/a2dp-codecs.h:

   The proximinity-helper is a binary delivered to libexec, so this is okay.  
   However, the LICENSE file should probably highlight that it ships this GPL
   binary.

   More seriously, the a2dp-codecs.h file is included in the following 
   bluetooth module files bluetooth-util.c and module-bluetooth-device.c 

   Is this an error, or should the LICENSE file highlight that building the 
   bluetooth module also affects the PulseAudio license.

3) The LICENSE file highlights that the echo-cancel module is under a more
   permissive license.  I notice that some code uses the MIT license.  Should
   this be highlighted as well if you are going to highlight more permissive
   licensing in the module?

   - pulseaudio-1.0/src/modules/reserve-monitor.c
   - pulseaudio-1.0/src/modules/reserve.c
   - pulseaudio-1.0/src/pulsecore/rtkit.c

   Also, this file is under a more permissive Sun Public Domain license:
   - pulseaudio-1.0/src/pulsecore/g711.c:

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.