[pulseaudio-tickets] [Bug 41539] Fix PulseAudio 1.0 build for Solaris

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41539

Brian Cameron <brian.cameron at oracle.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52060|0                           |1
        is obsolete|                            |

--- Comment #10 from Brian Cameron <brian.cameron at oracle.com> 2011-10-19 10:57:14 PDT ---
Created attachment 52533
  --> https://bugs.freedesktop.org/attachment.cgi?id=52533
Updated patch


You are right.  After doing further research, the right fix is not to modify
the pkg-config files to make things like against libpulsecore.  

Instead the issues seem to be caused by the fact that libpulsecommon includes
pulsecore/pstream.c, which includes pulsecore/core-scache.h to gain access to
the PA_SCACHE_ENTRY_SIZE_MAX #define.

Moving this #define so it is in pulsecore/memchunk.h (a header already
associated with libpulsecommon and also included by pulsecore/scache.h) and
fixing pstream.c to include memchunk.h fixes this issue.

I am not sure if this is the best way to fix this issue.  If the PulseAudio
maintainers want to rearrange the header files in some other way to avoid the
libpulsecommon pstream.c file needing to include pulsecore/core-scache.h, that
is obviously okay.

I also notice that src/Makefile needs to be updated so connect_stress links
with libpulsecore, so this is also fixed in this patch.

This patch is pretty simple, and it makes PulseAudio link properly on Solaris
so libpulsecore does not need to be linked into libpulsecommon.  Can this go
upstream?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.