[pulseaudio-tickets] [Bug 40616] git master of both pulseaudio and pavucontrol seem to overlink (i.e. pavucontrol requires libpulsecommon-0.99.so)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40616

Colin Guthrie <fdo at colin.guthr.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Colin Guthrie <fdo at colin.guthr.ie> 2011-09-05 01:35:09 PDT ---
commit 03b97d0e08ed6a8578a94970390c7347d0deb9de
Author: Colin Guthrie <colin at ...>
Date:   Sun Sep 4 21:05:14 2011 +0200

    formats: Export more functions needed for a clean build.

    All of these functions are not actually defined in format.h
    (they are defined in internal.h) and thus should really be
    included only in libpulsecommon and implemented in a separate
    source file.

    However if that approach was taken, and these functions were
    included in libpulsecommon, then they would have a link time
    dependancy on libpulse (as these four functions use other
    pa_format_info_* functions). As the opposite is already true
    (libpulse depends on libpulsecommon), this is not possible as
    it creates a circular dependancy.

    Thus the only option is to just to include these four functions
    in the map-file, but not actually export any public headers for
    them. Of course users could use this implementation by defining
    them in their own headers, but the only practical problem
    with this approach is naming conflicts which is unlikely to happen.

    fdo#40616

commit 1595608b0b1da794ad79e42c0131c9cb523e9b0b
Author: Colin Guthrie <colin at ...>
Date:   Sun Sep 4 20:40:21 2011 +0200

    formats: The format code should be in libpulse, not libpulsecommon

    Without this change any applications calling e.g. pa_format_info_new()
    and friends will be explicitly linked against libpulsecommon-$MAJORMINOR.so
    which is something we specifically avoid as it may contain ABI/API unstable
    functions.

    Also ensure we export pa_format_info_from_string() for external use.

    fdo#40616

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.