[pulseaudio-tickets] [Bug 40636] Change public facing references to "sync_volumes"

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 13 13:26:39 PDT 2011


https://bugs.freedesktop.org/show_bug.cgi?id=40636

Colin Guthrie <fdo at colin.guthr.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|pulseaudio-bugs at lists.freed |fdo at colin.guthr.ie
                   |esktop.org                  |

--- Comment #5 from Colin Guthrie <fdo at colin.guthr.ie> 2011-09-13 13:26:39 PDT ---
Created an attachment (id=51164)
 View: https://bugs.freedesktop.org/attachment.cgi?id=51164
 Review: https://bugs.freedesktop.org/review?bug=40636&attachment=51164

Patch to rename things.

OK, on a clean clone, I just did:

grep -rli "sync[-_]volume" . | xargs sed -i
's/sync_volume/deferred_volume/g;s/PA_SINK_SYNC_VOLUME/PA_SINK_DEFERRED_VOLUME/g;s/PA_SOURCE_SYNC_VOLUME/PA_SOURCE_DEFERRED_VOLUME/g;s/sync-volume/deferred-volume/g'


This leaves: 

[colin at jimmy src (master)]$ ccgrep SYNC_VOLUME .
./pulsecore/source.c:        case PA_SOURCE_MESSAGE_SYNC_VOLUMES:
./pulsecore/sink.h:    PA_SINK_MESSAGE_SYNC_VOLUMES,
./pulsecore/sink.c:        case PA_SINK_MESSAGE_SYNC_VOLUMES:
./pulsecore/source.h:    PA_SOURCE_MESSAGE_SYNC_VOLUMES,


Which I think I want to keep as the message name describes the action which I
think is valid.

The attached patch implements this and passes a distcheck.

If no one spots anything obvious I'll commit this tomorrow morning.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the pulseaudio-bugs mailing list