[pulseaudio-tickets] [Bug 53923] New: pa_sink_input_request_rewind() has a nonsensical check

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=53923

             Bug #: 53923
           Summary: pa_sink_input_request_rewind() has a nonsensical check
    Classification: Unclassified
           Product: PulseAudio
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: core
        AssignedTo: pulseaudio-bugs at lists.freedesktop.org
        ReportedBy: tanuk at iki.fi
         QAContact: pulseaudio-bugs at lists.freedesktop.org
                CC: lennart at poettering.net


pa_sink_input_request_rewind() contains this:

    i->thread_info.rewrite_flush =
        i->thread_info.rewrite_flush ||
        (flush && i->thread_info.rewrite_nbytes != 0);

The "i->thread_info.rewrite_nbytes != 0" doesn't do anything useful, so all it
does is create confusion (it's otherwise harmless).

It would be good to test the change at least a bit before pushing. I'm not
willing to do that right now, which is why I'm filing this bug.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.