[pulseaudio-tickets] [Bug 58522] New: BlueZ support enabled even when bluez is missing

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=58522

          Priority: medium
            Bug ID: 58522
                CC: lennart at poettering.net
          Assignee: pulseaudio-bugs at lists.freedesktop.org
           Summary: BlueZ support enabled even when bluez is missing
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: dan at danny.cz
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: build-system
           Product: PulseAudio

The logic for checking BlueZ support seems broken to me. I had SBC development
file installed, no BlueZ development files, BlueZ still still got enabled.

from configure log:
...
checking for DBUS... yes
checking for dbus_watch_get_unix_fd... yes
checking for BLUEZ... no
checking for SBC... yes
checking for UDEV... yes
...
    Enable Xen PV driver:          no
    Enable D-Bus:                  yes
      Enable BlueZ:                yes
    Enable udev:                   yes
      Enable HAL->udev compat:     yes
....


from configure.ac:
...
#### BlueZ support (optional, dependant on D-Bus) ####

AC_ARG_ENABLE([bluez],
    AS_HELP_STRING([--disable-bluez],[Disable optional BlueZ support]))

AS_IF([test "x$enable_bluez" != "xno"],
    [PKG_CHECK_MODULES(BLUEZ, [ bluez >= 4.99 ], HAVE_BLUEZ=1, HAVE_BLUEZ=0)],
    HAVE_BLUEZ=0)
AS_IF([test "x$enable_bluez" != "xno"],
    [PKG_CHECK_MODULES(SBC, [ sbc >= 1.0 ], HAVE_BLUEZ=1, HAVE_BLUEZ=0)],
    HAVE_BLUEZ=0)
AS_IF([test "x$HAVE_DBUS" != "x1"], HAVE_BLUEZ=0)

AS_IF([test "x$enable_bluez" = "xyes" && test "x$HAVE_BLUEZ" = "x0"],
    [AC_MSG_ERROR([*** BLUEZ support not found (requires BlueZ, sbc, and
D-Bus)])])

AC_SUBST(BLUEZ_CFLAGS)
AC_SUBST(BLUEZ_LIBS)
AC_SUBST(HAVE_BLUEZ)
AM_CONDITIONAL([HAVE_BLUEZ], [test "x$HAVE_BLUEZ" = x1])
...

so instead of (DBUS && SBC && BLUEZ) this is something like (DBUS && (BLUEZ ||
SBC))

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20121219/491b98e5/attachment-0001.html>