[pulseaudio-tickets] [Bug 43503] Xen paravirtualized driver frontend module

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43503

Colin Guthrie <fdo at colin.guthr.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Colin Guthrie <fdo at colin.guthr.ie> 2012-03-11 14:37:10 PDT ---
Hello.

Thanks for this patch.

I've now included this in git master scheduled for inclusion in PA 2.0 due out
shortly. While we're technically in feature freeze I'm happy to include this as
it has little impact on any other system without specific manual configuration.
If it included changes to udev-detect I'd probably not have included it
(although my own delays in reviewing it and getting it in would have to be
considered too!).

Anyway, I had to make a couple tweaks:

1. Mention the two headers in the Makefile.am to ensure they are distributed
(i.e. in the tarball)
2. Change the path to the headers: You put them in the xen folder, but this
only worked for in-tree builds, not out-of-tree builds (which is needed for
"make distcheck"). I simply added the include path in the CFLAGS and dropped
the xen/ prefix in the .c file.
3. Moved the .c file to the xen folder. Maarten originally stated it should go
in src/modules which was correct at the time, but as you added a couple
companion files, it makes sense to put everything in the folder.
4. I removed trailing whitespace from the .c files.

As the .h headers are copied from the kernel I didn't touch them for whitespace
changes (not even sure if they need them). We do have some external files
included from other projects already - e.g. see the sbc files in the bluetooth
folder. We have some automatic stuff to update them directly (via gitweb to
save a real clone) from their primary location. It would be great if you could
supply a rule similar to "make update-sbc" that would pull in any changes to
these files from their upstream location.


As for your comments regarding the detection module, I'd be relatively happy
for udev-detect to be modified to effectively become a no-op when on a guest,
but I think that should be all it does.

The full, independent xen-detect module could be mostly stand-alone.

I think in terms of activating it automatically, we should likely change the
default.pa to have a ".include /etc/pulse/default.d/detect" line, then put a
small file in that folder: /etc/pulse/default.d/detect/xen.pa that actually
does the "load-module module-xen-detect" stuff. This way a non-xen machine
(i.e. one who likely does not install the distribution pulse-module-xen package
will not waste cycles loading that module.

That's likely not super clearly written, so just bug me for an explanation on
IRC if needed :)

I'll close this bug, but feel free to reopen or open a new one for the
detection module.

Many thanks for your contribution :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.