[pulseaudio-tickets] [Bug 55607] New: crash because of null string on solaris

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55607

          Priority: medium
            Bug ID: 55607
                CC: lennart at poettering.net
          Assignee: pulseaudio-bugs at lists.freedesktop.org
           Summary: crash because of null string on solaris
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: pierre-bugzilla at ossman.eu
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: core
           Product: PulseAudio

Solaris' printf doesn't support NULL arguments for %s, which pulseaudio
unfortunately gives it now and then. Making a safe printf wrapper is just a
major pain, so I guess we'll have to find the offenders that provide null
pointers. The most glaring one is pa_thread_get_name():

Index: src/pulsecore/thread-posix.c
===================================================================
--- src/pulsecore/thread-posix.c    (revision 25954)
+++ src/pulsecore/thread-posix.c    (working copy)
@@ -211,6 +211,9 @@
     }
 #endif

+    if (t->name == NULL)
+        return "(null)";
+
     return t->name;
 }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20121004/e5f8ab31/attachment.html>