[pulseaudio-tickets] [Bug 66774] New: crash when shutting down without any modules loaded

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=66774

          Priority: medium
            Bug ID: 66774
                CC: lennart at poettering.net
          Assignee: pulseaudio-bugs at lists.freedesktop.org
           Summary: crash when shutting down without any modules loaded
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: pierre-bugzilla at ossman.eu
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: core
           Product: PulseAudio

If all the modules given fail to load, the daemon will try to shut down and
crash when trying to clean up:

E: [pulseaudio] main.c: Module load failed.
E: [pulseaudio] main.c: Failed to initialize daemon.
E: [pulseaudio] xmalloc.c: Assertion 'size > 0' failed at pulse/xmalloc.c:62,
function pa_xmalloc(). Aborting.

Easily fixed with this patch:

Index: src/pulsecore/module.c
===================================================================
--- src/pulsecore/module.c    (revision 27650)
+++ src/pulsecore/module.c    (working copy)
@@ -217,6 +217,9 @@
     pa_assert(c);
     pa_assert(c->modules);

+    if (pa_idxset_isempty(c->modules))
+        return;
+
     /* Unload modules in reverse order by default */
     indices = pa_xnew(uint32_t, pa_idxset_size(c->modules));
     i = 0;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20130710/a11c88a6/attachment.html>