[pulseaudio-tickets] [Bug 66855] module-tunnel screws up latency calculation on suspend

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jul 12 07:39:07 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=66855

--- Comment #1 from Pierre Ossman <pierre-bugzilla at ossman.eu> ---
Very silly bug. The worker threads in module-tunnel looked at the wrong state
variable. Fix:

Index: src/modules/module-tunnel.c
===================================================================
--- src/modules/module-tunnel.c    (revision 27672)
+++ src/modules/module-tunnel.c    (revision 27674)
@@ -502,9 +502,9 @@
             /* First, change the state, because otherwise pa_sink_render()
would fail */
             if ((r = pa_sink_process_msg(o, code, data, offset, chunk)) >= 0)
{

-                stream_cork_within_thread(u, u->sink->state ==
PA_SINK_SUSPENDED);
+                stream_cork_within_thread(u, u->sink->thread_info.state ==
PA_SINK_SUSPENDED);

-                if (PA_SINK_IS_OPENED(u->sink->state))
+                if (PA_SINK_IS_OPENED(u->sink->thread_info.state))
                     send_data(u);
             }

@@ -613,7 +613,7 @@
             int r;

             if ((r = pa_source_process_msg(o, code, data, offset, chunk)) >=
0)
-                stream_cork_within_thread(u, u->source->state ==
PA_SOURCE_SUSPENDED);
+                stream_cork_within_thread(u, u->source->thread_info.state ==
PA_SOURCE_SUSPENDED);

             return r;
         }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20130712/a5687bcc/attachment.html>


More information about the pulseaudio-bugs mailing list