[pulseaudio-tickets] [Bug 42804] raop module does not work with shairport

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42804

--- Comment #50 from Hajime Fujita <crisp.fujita at nifty.com> ---
Hi Matthias,

Come to think of it, when I first try your original patch, I didn't see
retransmission request burst, that means it also worked for my device. Sorry
for having jumped into the wrong conclusion.

> A possible explanation could be that my remote device accepts re-sent audio packets at the streaming port > (regardless of payload type(!)) if the sequence number matches the one requested.

This would make sense. In principle there is no order guarantee for UDP/IP, so
the device should expect reordered/delayed packet.
So if the device ignores the payload type field, the behavior would be the same
as for natural reordered packet.


BTW, by reading raop_packet_buffer.c, I realized that pb_get_packet() did not
work (i.e. did not copy the data to the given user buffer).
> packet_data = packet->packet;
This is just manipulating the pointer, not touching the data referenced by the
pointer.

FYI, in C, it should have been either:
    for (i = 0; i < len; i++)
        packet_data[i] = packet->packet[i];
or
    memcpy(packet_data, packet->packet, len);

As a result, even the retransmission packet was accepted by the device, we
could not expect to hear a meaningful sound from it.
Probably this is the reason that I experienced sound glitch on retransmission
when I tried your patch first.

If you don't mind, I'll take a look and rewrite the code. (At the same time
I'll adapt the code to the latest raop2-for-merge branch.)


Thanks,
Hajime

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20130904/524a3d5d/attachment.html>