[pulseaudio-tickets] [Bug 47899] Stuttering when using "Simultaneous output"

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47899

--- Comment #26 from Tanu Kaskinen <tanuk at iki.fi> ---
Thanks for the patch! Here's some feedback:

You may not call pa_sink_input_set_requested_latency_within_thread() from
sink_update_requested_latency(), because the former must be called from the
sink input's thread, but the latter is called from the combine sink's thread. I
think there needs to be a new message that is sent to the sink inputs with
pa_asyncmsgq_post() when the combine sink's requested latency changes.

When creating new outputs, the hard-coded BLOCK_USEC value is used as the
initial requested latency for sink inputs, but we should use the combine sink's
current requested latency instead.

I don't understand what benefit there is for lowering BLOCK_USEC down to 20 ms.
The stated reason is to help low latency applications, but if the applications
want low latency, they should request low latency, and thanks to this patch,
that should result in low latency (as long as the underlying sinks support
that).

You should set the PA_SINK_DYNAMIC_LATENCY flag for the combine sink now that
dynamic latency has been implemented.

I would prefer to have the added debug messages in the core, instead of
(potentially) duplicating the same message in multiple modules.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20140401/9e06ae5a/attachment.html>