[pulseaudio-tickets] [Bug 83229] New: Patch: Do not instantiate cardwidget, devicewidget and rolewidget with a type of EventBox

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=83229

          Priority: medium
            Bug ID: 83229
                CC: lennart at poettering.net
          Assignee: pulseaudio-bugs at lists.freedesktop.org
           Summary: Patch: Do not instantiate cardwidget, devicewidget and
                    rolewidget with a type of EventBox
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: jwrdegoede at fedoraproject.org
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: pavucontrol
           Product: PulseAudio

Created attachment 105412
  --> https://bugs.freedesktop.org/attachment.cgi?id=105412&action=edit
[PATCH] Do not instantiate cardwidget, devicewidget and rolewidget with a type
of EventBox

RoleWidget::create contains:
    x->get_widget_derived("streamWidget", w);

But streamWidget is defined as following in the glade file:
<object class="GtkEventBox" id="streamWidget">

Where as RoleWidget is derived from [Minimal]StreamWidget, which is derived
from Gtk::VBox, so this is clearly wrong.

Adding:
printf("rolewidget type: %s\n", g_type_name(G_TYPE_FROM_INSTANCE(w->gobj())));
for debugging shows that this really leads to RoleWidget being instantiated
as an EventBox (yet things still work due to sheer luck).

This commit fixes this, by putting the streamWidget id at the right level of
the hierarchy in the glade file (and likewise for cardWidget and deviceWidget).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20140829/7c58805d/attachment.html>