[pulseaudio-tickets] [Bug 42804] raop module does not work with shairport

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42804

--- Comment #61 from Alex Zuepke <blexi at web.de> ---
(In reply to comment #60)
> Using Fujita's code on ubuntu I lose my local sound devices. How do I retain
> my loxal sound devices, is it code or config driven?

I tried Hajime's raop2-for-merge2 branch on my Linux Mint 16 today.
I observed the same effect (no local sound devices). Both local sound and the
connection to my AppleTV 3 failed with "invalid sample format specification" in
the logs, which made me curious.

I tracked the problem: the bug seems to be in PA's handling of configuration
data. If no explicit value is provided, PA should use the default value.
Instead, garbage on stack was returned. The following patch fixes the default
initialization, and both local sound and AppleTV are working fine now.

diff --git a/src/pulsecore/modargs.c b/src/pulsecore/modargs.c
index 432e480..6855b6a 100644
--- a/src/pulsecore/modargs.c
+++ b/src/pulsecore/modargs.c
@@ -369,6 +369,7 @@ int pa_modargs_get_sample_rate(pa_modargs *ma, uint32_t
*rate) {

     pa_assert(rate);

+    rate_local = *rate;
     if ((pa_modargs_get_value_u32(ma, "rate", &rate_local)) < 0 ||
         rate_local <= 0 ||
         rate_local > PA_RATE_MAX)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20140621/611e64ee/attachment.html>