[pulseaudio-tickets] [Bug 78564] New: Untranslatable string due to wrong usage of gettext

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=78564

          Priority: medium
            Bug ID: 78564
                CC: lennart at poettering.net
          Assignee: pulseaudio-bugs at lists.freedesktop.org
           Summary: Untranslatable string due to wrong usage of gettext
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: aspotashev at gmail.com
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: daemon
           Product: PulseAudio

Untranslatable string due to wrong usage of gettext here in src/daemon/main.c,
line 271:
    pa_log_info(_("Successfully changed user to \"" PA_SYSTEM_USER "\"."));

Because Gettext can only extract string constants and cannot parse C
preprocessor variables, it extracts only the first part - "Successfully changed
user to \"". Then, because the whole string along with PA_SYSTEM_USER, etc is
passed into the _() call, translation for that is not found and the string is
never translated into any language.

Solution: pass PA_SYSTEM_USER as "%s", like this:
    pa_log_info(_("Successfully changed user to \"%s\"."), PA_SYSTEM_USER);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20140511/1f9d9e41/attachment-0001.html>