<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Possible memory leak in src/modules/module-filter-apply.c"
href="https://bugs.freedesktop.org/show_bug.cgi?id=95293#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Possible memory leak in src/modules/module-filter-apply.c"
href="https://bugs.freedesktop.org/show_bug.cgi?id=95293">bug 95293</a>
from <span class="vcard"><a class="email" href="mailto:arun@accosted.net" title="Arun Raghavan <arun@accosted.net>"> <span class="fn">Arun Raghavan</span></a>
</span></b>
<pre>Hey Sachin, you're right. Looking at the code, you'll also notice that fltr is
being leaked. Would you like to submit a fix for this? It might make sense to
initialise fltr and module_name as NULL, and then just have something like:
if (something) {
pa_log(...);
goto done;
}
if (something else) {
pa_log(...);
goto done;
}
done:
pa_xfree(module_name);
pa_xfree(fltr);
return ...
This makes it more likely that we won't miss freeing if we add additional
conditions.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>