<html>
    <head>
      <base href="https://bugs.freedesktop.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - module-ladspa-sink: How can I use run_adding?"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=105806">105806</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>module-ladspa-sink: How can I use run_adding?
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>PulseAudio
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>x86-64 (AMD64)
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux (All)
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>enhancement
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>modules
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>pulseaudio-bugs@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>ovvv@web.de
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>pulseaudio-bugs@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>lennart@poettering.net
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=138417" name="attach_138417" title="patch for run_adding">attachment 138417</a> <a href="attachment.cgi?id=138417&action=edit" title="patch for run_adding">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=105806&attachment=138417'>[review]</a>
patch for run_adding

The run_adding function provided by some LADSPA plugins can be used to add the
plugin output scaled with a specified gain instead of using its output
directly.
So you can use it to specify the wet/dry level, can't you?

I've tried to implement it to module-ladspa-sink. The patch is in the
attachment.

When I tested it with the glame butterworth lowpass filter (butterworth_1902.so
from swh plugins), the debug message telling the configured gain appeared.
However, run_adding didn't work, I've set run_adding_gain to 0.1 and 10, the
output was the same both times, as though run instead of run_adding was used.
I've also tried setting the gain directly before run_adding is executed:
<a href="https://pastebin.com/mj3tBgaB">https://pastebin.com/mj3tBgaB</a>
But it didn't change anything.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the QA Contact for the bug.</li>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>