<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [PATCH] build: support building with elogind" href="https://bugs.freedesktop.org/show_bug.cgi?id=107050#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [PATCH] build: support building with elogind" href="https://bugs.freedesktop.org/show_bug.cgi?id=107050">bug 107050</a> from <a class="email" href="mailto:tanuk@iki.fi" title="Tanu Kaskinen <tanuk@iki.fi>"> Tanu Kaskinen</a> <pre>I think the patch should fulfil the following requirements: input: --enable-systemd-login --enable-elogind-login installed: libsystemd, libelogind output: error, can't enable both input: --enable-systemd-login installed: libsystemd, libelogind output: use libsystemd input: --enable-elogind-login installed: libsystemd, libelogind output: use libelogind input: --enable-systemd-login installed: libelogind output: error, systemd requested but not installed input: --enable-elogind-login installed: libsystemd output: error, elogind requested but not installed input: no configure args installed: libsystemd, libelogind output: use libsystemd input: no configure args installed: libsystemd output: use libsystemd input: no configure args installed: libelogind output: use libelogind Currently the patch doesn't handle all cases correctly. For example, if both libsystemd and libelogind are installed, but only --enable-systemd-login is passed to configure, the patch produces an error. Can you send a revised patch to the mailing list? I find it easier to comment on the details of the code that way. Subscribe here: <a href="https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss">https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss</a> Here are instructions for using git send-email, in case you find that useful: <a href="https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/">https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/</a></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>