[pulseaudio-commits] r1127 - in /trunk/src/pulse: client-conf.c client-conf.h context.c

[svnmailer-noreply at 0pointer.de]

Author: lennart
Date: Thu Jul 20 23:28:44 2006
New Revision: 1127

URL: http://0pointer.de/cgi-bin/viewcvs.cgi?rev=1127&root=pulseaudio&view=rev
Log:
remove configurable client access group, since can never work on Linux anway, since SCM_CREDENTAILS doesn't allow sending supplementary GIDs

Modified:
    trunk/src/pulse/client-conf.c
    trunk/src/pulse/client-conf.h
    trunk/src/pulse/context.c

Modified: trunk/src/pulse/client-conf.c
URL: http://0pointer.de/cgi-bin/viewcvs.cgi/trunk/src/pulse/client-conf.c?rev=1127&root=pulseaudio&r1=1126&r2=1127&view=diff
==============================================================================
--- trunk/src/pulse/client-conf.c (original)
+++ trunk/src/pulse/client-conf.c Thu Jul 20 23:28:44 2006
@@ -64,7 +64,6 @@
     .autospawn = 0,
     .cookie_file = NULL,
     .cookie_valid = 0,
-    .access_group = NULL
 };
 
 pa_client_conf *pa_client_conf_new(void) {
@@ -73,7 +72,6 @@
     c->daemon_binary = pa_xstrdup(PA_BINARY);
     c->extra_arguments = pa_xstrdup("--log-target=syslog --exit-idle-time=5");
     c->cookie_file = pa_xstrdup(PA_NATIVE_COOKIE_FILE);
-    c->access_group = pa_xstrdup(PA_ACCESS_GROUP);
     
     return c;
 }
@@ -86,7 +84,6 @@
     pa_xfree(c->default_source);
     pa_xfree(c->default_server);
     pa_xfree(c->cookie_file);
-    pa_xfree(c->access_group);
     pa_xfree(c);
 }
 int pa_client_conf_load(pa_client_conf *c, const char *filename) {
@@ -103,7 +100,6 @@
         { "default-server",         pa_config_parse_string,  NULL },
         { "autospawn",              pa_config_parse_bool,    NULL },
         { "cookie-file",            pa_config_parse_string,  NULL },
-        { "access-group",           pa_config_parse_string,  NULL },
         { NULL,                     NULL,                    NULL },
     };
 
@@ -114,7 +110,6 @@
     table[4].data = &c->default_server;
     table[5].data = &c->autospawn;
     table[6].data = &c->cookie_file;
-    table[7].data = &c->access_group;
 
     f = filename ?
         fopen((fn = pa_xstrdup(filename)), "r") :

Modified: trunk/src/pulse/client-conf.h
URL: http://0pointer.de/cgi-bin/viewcvs.cgi/trunk/src/pulse/client-conf.h?rev=1127&root=pulseaudio&r1=1126&r2=1127&view=diff
==============================================================================
--- trunk/src/pulse/client-conf.h (original)
+++ trunk/src/pulse/client-conf.h Thu Jul 20 23:28:44 2006
@@ -27,7 +27,7 @@
 /* A structure containing configuration data for PulseAudio clients. */
 
 typedef struct pa_client_conf {
-    char *daemon_binary, *extra_arguments, *default_sink, *default_source, *default_server, *cookie_file, *access_group;
+    char *daemon_binary, *extra_arguments, *default_sink, *default_source, *default_server, *cookie_file;
     int autospawn;
     uint8_t cookie[PA_NATIVE_COOKIE_LENGTH];
     int cookie_valid; /* non-zero, when cookie is valid */

Modified: trunk/src/pulse/context.c
URL: http://0pointer.de/cgi-bin/viewcvs.cgi/trunk/src/pulse/context.c?rev=1127&root=pulseaudio&r1=1126&r2=1127&view=diff
==============================================================================
--- trunk/src/pulse/context.c (original)
+++ trunk/src/pulse/context.c Thu Jul 20 23:28:44 2006
@@ -428,14 +428,9 @@
 #ifdef HAVE_CREDS
 {
     pa_creds ucred;
-    gid_t g;
 
     ucred.uid = getuid();
     ucred.gid = getgid();
-                   
-    if ((g = pa_get_gid_of_group(c->conf->access_group)) != (gid_t) -1) 
-        if (pa_check_in_group(g) > 0)
-            ucred.gid = g;
     
     pa_pstream_send_tagstruct_with_creds(c->pstream, t, &ucred);
 }