[pulseaudio-commits] [SCM] PulseAudio Sound Server branch, master, updated. v0.9.16-test2-37-g2bbdf63

[Lennart Poettering]

This is an automated email from the git hooks/post-receive script. It was
generated because of a push to the "PulseAudio Sound Server" repository.

The master branch has been updated
      from  18433c19b690432179e9a0ed83eff611f5cecc67 (commit)

- Log -----------------------------------------------------------------
2bbdf63 udev: explain what happened when inotify_add_watch() returned ENOSPC, rhbz #513571
-----------------------------------------------------------------------

Summary of changes:
 src/modules/module-udev-detect.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

-----------------------------------------------------------------------

commit 2bbdf631f8ef1029558be19bcf8a9176a5932b8b
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Jul 24 13:58:22 2009 +0200

    udev: explain what happened when inotify_add_watch() returned ENOSPC, rhbz #513571

diff --git a/src/modules/module-udev-detect.c b/src/modules/module-udev-detect.c
index c8ec2bf..11de1cc 100644
--- a/src/modules/module-udev-detect.c
+++ b/src/modules/module-udev-detect.c
@@ -336,8 +336,18 @@ static int setup_inotify(struct userdata *u) {
         pa_close(u->inotify_fd);
         u->inotify_fd = -1;
 
-        if (saved_errno == ENOENT)
+        if (saved_errno == ENOENT) {
+            pa_log_debug("/dev/snd/ is apparently not existing yet, retrying to create inotify watch later.");
             return 0;
+        }
+
+        if (saved_errno == ENOSPC) {
+            pa_log("You apparently ran out of inotify watches, probably because Tracker/Beagle took them all away. "
+                   "I wished people would do their homework first and fix inotify before using it for watching whole "
+                   "directory trees which is something the current inotify is certainly not useful for. "
+                   "Please make sure to drop the Tracker/Beagle guys a line complaining about their broken use of inotify.");
+            return 0;
+        }
 
         pa_log("inotify_add_watch() failed: %s", pa_cstrerror(saved_errno));
         return -1;

-- 
hooks/post-receive
PulseAudio Sound Server