[pulseaudio-commits] src/modules

Tanu Kaskinen tanuk at kemper.freedesktop.org
Tue Apr 2 08:56:33 PDT 2013


 src/modules/alsa/module-alsa-card.c |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 77347e1e9100fd2062c28269497645decd9457bc
Author: Maarten Lankhorst <maarten.lankhorst at canonical.com>
Date:   Tue Apr 2 11:27:38 2013 +0200

    alsa: skip eld initialization if hctl_handle is NULL
    
    Due to a misconfiguration on my side my hdmi card didn't load with
    snd-hda-codec-hdmi but through the fallback mechanism. Pulseaudio
    would crash during early because hctl_handle was null, so skip
    init_eld_ctls when hctl_handle is null to prevent a crash.
    
    Thanks to David Henningsson for helping me find the underlying issue.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com>

diff --git a/src/modules/alsa/module-alsa-card.c b/src/modules/alsa/module-alsa-card.c
index 3b96cea..2529c0d 100644
--- a/src/modules/alsa/module-alsa-card.c
+++ b/src/modules/alsa/module-alsa-card.c
@@ -437,6 +437,9 @@ static void init_eld_ctls(struct userdata *u) {
     void *state;
     pa_device_port *port;
 
+    if (!u->hctl_handle)
+        return;
+
     PA_HASHMAP_FOREACH(port, u->card->ports, state) {
         pa_alsa_port_data *data = PA_DEVICE_PORT_DATA(port);
         snd_hctl_elem_t* hctl_elem;



More information about the pulseaudio-commits mailing list