[pulseaudio-commits] 2 commits - src/daemon src/pulsecore

[Tanu Kaskinen]

 src/daemon/ltdl-bind-now.c |    1 +
 src/pulsecore/module.c     |    8 +++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

New commits:
commit dc68fcb33f04e3b1420495a2c0a5e61b41e70d1b
Author: Tanu Kaskinen <tanuk at iki.fi>
Date:   Tue Mar 12 19:05:58 2013 +0200

    ltdl-bind-now: Log an error in case of failures

diff --git a/src/daemon/ltdl-bind-now.c b/src/daemon/ltdl-bind-now.c
index cab0405..6fd66e9 100644
--- a/src/daemon/ltdl-bind-now.c
+++ b/src/daemon/ltdl-bind-now.c
@@ -74,6 +74,7 @@ static lt_module bind_now_open(lt_user_data d, const char *fname, lt_dladvise ad
     pa_assert(fname);
 
     if (!(m = dlopen(fname, PA_BIND_NOW))) {
+        pa_log(_("Failed to open module %s: %s"), fname, dlerror());
         lt_dlseterror(LT_ERROR_CANNOT_OPEN);
         return NULL;
     }

commit cfb609d4f6ddb8270f85ed0fd0c824be2e21469f
Author: Tanu Kaskinen <tanuk at iki.fi>
Date:   Tue Mar 12 19:05:15 2013 +0200

    module: Don't use lt_dlerror(), it's useless

diff --git a/src/pulsecore/module.c b/src/pulsecore/module.c
index 47bcd3f..268d85d 100644
--- a/src/pulsecore/module.c
+++ b/src/pulsecore/module.c
@@ -66,7 +66,13 @@ pa_module* pa_module_load(pa_core *c, const char *name, const char *argument) {
     m->proplist = pa_proplist_new();
 
     if (!(m->dl = lt_dlopenext(name))) {
-        pa_log("Failed to open module \"%s\": %s", name, lt_dlerror());
+        /* We used to print the error that is returned by lt_dlerror(), but
+         * lt_dlerror() is useless. It returns pretty much always "file not
+         * found". That's because if there are any problems with loading the
+         * module with normal loaders, libltdl falls back to the "preload"
+         * loader, which never finds anything, and therefore says "file not
+         * found". */
+        pa_log("Failed to open module \"%s\".", name);
         goto fail;
     }