[pulseaudio-commits] src/modules

[Tanu Kaskinen]

 src/modules/alsa/alsa-ucm.c |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit bee86af3ccc247834bf38a57296958f9cd35ffc4
Author: Tanu Kaskinen <tanu.kaskinen at linux.intel.com>
Date:   Mon Nov 18 18:48:05 2013 +0200

    ucm: Add a FIXME comment about bad error handling

diff --git a/src/modules/alsa/alsa-ucm.c b/src/modules/alsa/alsa-ucm.c
index ef3ddb2..ac7f70d 100644
--- a/src/modules/alsa/alsa-ucm.c
+++ b/src/modules/alsa/alsa-ucm.c
@@ -1125,6 +1125,9 @@ static void alsa_mapping_add_ucm_modifier(pa_alsa_mapping *m, pa_alsa_ucm_modifi
     }
 
     if (channel_str) {
+        /* FIXME: channel_str is unsanitized input from the UCM configuration,
+         * we should do proper error handling instead of asserting.
+         * https://bugs.freedesktop.org/show_bug.cgi?id=71823 */
         pa_assert_se(pa_atou(channel_str, &channels) == 0 && channels < PA_CHANNELS_MAX);
         pa_log_debug("Got channel count %" PRIu32 " for modifier", channels);
     }