[pulseaudio-commits] src/modules

David Henningsson diwic at kemper.freedesktop.org
Mon Feb 16 06:04:43 PST 2015


 src/modules/module-loopback.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit aa3a27d5cdad9dd43b9fe79a13fd09b50d4b7682
Author: Alexander E. Patrakov <patrakov at gmail.com>
Date:   Wed Feb 11 21:50:47 2015 +0500

    module-loopback: don't use 0 for custom source output message id
    
    Message id 0 is PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY. So, every time PulseAudio
    sent PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY message to the loopback source output,
    it actually hit the SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT handler instead. As a
    result, the SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT handler was called when not
    intended, the default PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY handler was not called
    at all, and the latency was thus evaluated incorrectly.
    
    Reported-by: Georg Chini <georg at chini.tk>
    Signed-off-by: Alexander E. Patrakov <patrakov at gmail.com>

diff --git a/src/modules/module-loopback.c b/src/modules/module-loopback.c
index 7e2b92a..3b0d68d 100644
--- a/src/modules/module-loopback.c
+++ b/src/modules/module-loopback.c
@@ -126,7 +126,7 @@ enum {
 };
 
 enum {
-    SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT
+    SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT = PA_SOURCE_OUTPUT_MESSAGE_MAX,
 };
 
 static void enable_adjust_timer(struct userdata *u, bool enable);



More information about the pulseaudio-commits mailing list