[pulseaudio-commits] src/pulse

Tanu Kaskinen tanuk at kemper.freedesktop.org
Fri Sep 11 04:35:21 PDT 2015


 src/pulse/client-conf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c49c9bd3aa829fff9a3de0037330a7ed2cbdb9a5
Author: Felipe Sateler <fsateler at debian.org>
Date:   Thu Sep 10 21:42:48 2015 -0300

    Fix return code check of pa_append_to_home_dir
    
    It returns negative on error, zero on success.
    
    Found by coverity

diff --git a/src/pulse/client-conf.c b/src/pulse/client-conf.c
index 83331f8..47fe183 100644
--- a/src/pulse/client-conf.c
+++ b/src/pulse/client-conf.c
@@ -212,7 +212,7 @@ int pa_client_conf_load_cookie(pa_client_conf *c, uint8_t *cookie, size_t cookie
     if (r >= 0)
         return 0;
 
-    if (pa_append_to_home_dir(PA_NATIVE_COOKIE_FILE_FALLBACK, &fallback_path) > 0) {
+    if (pa_append_to_home_dir(PA_NATIVE_COOKIE_FILE_FALLBACK, &fallback_path) >= 0) {
         r = pa_authkey_load(fallback_path, false, cookie, cookie_length);
         pa_xfree(fallback_path);
         if (r >= 0)



More information about the pulseaudio-commits mailing list