[pulseaudio-commits] src/pulsecore

Tanu Kaskinen tanuk at kemper.freedesktop.org
Thu Feb 22 10:00:28 UTC 2018


 src/pulsecore/sink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d6e39b5e891c767dd42c369d9f118560b8bb24ae
Author: Tanu Kaskinen <tanuk at iki.fi>
Date:   Thu Feb 22 10:06:59 2018 +0200

    sink: don't sync monitor suspend state when unlinking
    
    When the sink is unlinked, there's no need to update the monitor suspend
    state. In fact, trying to do that causes an assertion failure, because
    pa_source_sync_suspend() wasn't written to handle the case where the
    sink is unlinked.

diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
index 0dfc91c8..f19e8b09 100644
--- a/src/pulsecore/sink.c
+++ b/src/pulsecore/sink.c
@@ -481,7 +481,7 @@ static int sink_set_state(pa_sink *s, pa_sink_state_t state, pa_suspend_cause_t
     }
 
 finish:
-    if ((suspending || resuming || suspend_cause_changed) && s->monitor_source)
+    if ((suspending || resuming || suspend_cause_changed) && s->monitor_source && state != PA_SINK_UNLINKED)
         pa_source_sync_suspend(s->monitor_source);
 
     return ret;



More information about the pulseaudio-commits mailing list