[pulseaudio-commits] Still Failing: pulseaudio/pulseaudio#508 (master - 2d9790f)

[Travis CI]

Build Update for pulseaudio/pulseaudio
-------------------------------------

Build: #508
Status: Still Failing

Duration: 1 min and 20 secs
Commit: 2d9790f (master)
Author: Lyndon Brown
Message: operation: avoid state change from final state

The internal operation_set_state function already returns early if the
new state is the same as the existing state. The attached patch extends
this to return early if already in a finalised (done/cancelled) state,
i.e. blocks attempts to re-finalise into a different state.

This helps avoid unlinking more than once (or crashing on ref count
assertion).

I was not certain whether an assertion would be a better alternative -
with such a crash helping highlight usage problems...

The situation that lead to this was the thought of someone stupidly
trying to pa_operation_cancel() a callback within the callback
execution itself, while designing a solution for a memory leak related
to cancellation within my Rust binding. While no-one should do such a
thing, if they did, they'd either trip up a ref count assertion, or the
operation would be unlinked twice, which would be bad. It's a simple
thing to catch and mitigate, and could prove to be a useful
bulletproofing measure for this function in general.

View the changeset: https://github.com/pulseaudio/pulseaudio/compare/613c2994af42...2d9790f566df

View the full build log and details: https://travis-ci.org/pulseaudio/pulseaudio/builds/404383604?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications







This email was sent to pulseaudio-commits at lists.freedesktop.org (mailto:pulseaudio-commits at lists.freedesktop.org)
unsubscribe from this list (http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=e50fcc59b4ae4390a17e95730f43187c.VaL8ccfxpUmpYz%2BvhvIcUhuRHk8%3D&r=https%3A%2F%2Fmandrillapp.com%2Funsub%3Fmd_email%3Dpulseaudio-commits%2540lists.freedesktop.org)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20180716/51a937ef/attachment.html>