[pulseaudio-commits] Branch 'next' - src/pulsecore

Tanu Kaskinen tanuk at kemper.freedesktop.org
Tue Jun 12 13:38:27 UTC 2018


 src/pulsecore/cli-command.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 166b585072f4d8f228976705b8c3a7042db5f065
Author: Tomaz Solc <tomaz.solc at tablix.org>
Date:   Tue May 29 09:22:59 2018 +0200

    cli-command: Report error in pa_play_file.
    
    Current code does not check whether pa_play_file call failed. Hence no error is
    reported in the cli interface if playback failed because e.g. file isn't
    readable by the daemon.

diff --git a/src/pulsecore/cli-command.c b/src/pulsecore/cli-command.c
index 44795b0d..defdac1e 100644
--- a/src/pulsecore/cli-command.c
+++ b/src/pulsecore/cli-command.c
@@ -1282,7 +1282,12 @@ static int pa_cli_command_play_file(pa_core *c, pa_tokenizer *t, pa_strbuf *buf,
         return -1;
     }
 
-    return pa_play_file(sink, fname, NULL);
+    if (pa_play_file(sink, fname, NULL) < 0) {
+        pa_strbuf_puts(buf, "Failed to play sound file.\n");
+        return -1;
+    }
+
+    return 0;
 }
 
 static int pa_cli_command_list_shared_props(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, bool *fail) {



More information about the pulseaudio-commits mailing list