[pulseaudio-commits] src/modules

Tanu Kaskinen tanuk at kemper.freedesktop.org
Fri May 4 14:52:08 UTC 2018


 src/modules/module-ladspa-sink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 66e8ec345336e2b0bd5aa0f4810319b03728ff96
Author: Sangchul Lee <sangchul1011 at gmail.com>
Date:   Fri May 4 02:00:26 2018 +0900

    ladspa-sink: fix incorrect error conditions
    
    fix codes to prevent null pointer dereference of cdata variable.
    
    Signed-off-by: Sangchul Lee <sc11.lee at samsung.com>

diff --git a/src/modules/module-ladspa-sink.c b/src/modules/module-ladspa-sink.c
index d677381d..c365b310 100644
--- a/src/modules/module-ladspa-sink.c
+++ b/src/modules/module-ladspa-sink.c
@@ -718,7 +718,7 @@ static int parse_control_parameters(struct userdata *u, const char *cdata, doubl
 
     pa_log_debug("Trying to read %lu control values", u->n_control);
 
-    if (!cdata && u->n_control > 0)
+    if (!cdata || u->n_control == 0)
         return -1;
 
     pa_log_debug("cdata: '%s'", cdata);



More information about the pulseaudio-commits mailing list