[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] client-conf: Avoid loading X11 properties unless SSH_CONNECTION is set

[Tanu Kaskinen]

Tanu Kaskinen pushed to branch master at PulseAudio / pulseaudio


Commits:
79a8efb4 by Carlos Garnacho at 2019-08-27T08:27:16Z
client-conf: Avoid loading X11 properties unless SSH_CONNECTION is set

Reading properties from the X11 root window is meant to provide 1:1 results
with reading the configuration directly in the local case. This configuration
is essentially different only in remote cases.

Add an extra check for the SSH_CONNECTION envvar, so we don't even need
opening a X11 display connection for IPC in the most usual case.

- - - - -


1 changed file:

- src/pulse/client-conf-x11.c


Changes:

=====================================
src/pulse/client-conf-x11.c
=====================================
@@ -43,6 +43,14 @@ int pa_client_conf_from_x11(pa_client_conf *c) {
 
     pa_assert(c);
 
+    /* Local connections will have configuration and X root window
+     * properties match 1:1, these paths are only strictly necessary
+     * for remote clients, so check for SSH_CONNECTION to make sure
+     * this is a remote session with X forwarding.
+     */
+    if (!getenv("SSH_CONNECTION"))
+        goto finish;
+
     if (!(dname = getenv("DISPLAY")))
         goto finish;
 



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/79a8efb45cb8304967baa2e8c6d6156478ce19d9

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/79a8efb45cb8304967baa2e8c6d6156478ce19d9
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20190827/ef9dbc42/attachment-0001.html>