From gitlab at gitlab.freedesktop.org Fri Jan 11 18:50:16 2019 From: gitlab at gitlab.freedesktop.org (Arun Raghavan) Date: Fri, 11 Jan 2019 18:50:16 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/paprefs][master] README: add a news item for the 1.1 release Message-ID: <5c38e568e0cb1_23e3fe705f656f4999195@gitlab-prod-gitlab-7f59448db7-6p2gh.mail> Arun Raghavan pushed to branch master at PulseAudio / paprefs Commits: 9928ba44 by Tanu Kaskinen at 2019-01-11T16:39:43Z README: add a news item for the 1.1 release - - - - - 1 changed file: - doc/README.html.in Changes: ===================================== doc/README.html.in ===================================== @@ -37,6 +37,11 @@ General Public License for more details.

News

+
Soon:

Version 1.1 released; replace +dbus-glib and libdbus with gdbus, use module-combine-sink instead of +module-combine

+
Sun Jul 29 2018:

Version 1.0 released; replace GConf with GSettings, port from GTK 2 to GTK 3, change build system from Autotools to View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/paprefs/commit/9928ba44de326c9bb8be3e14aed56b4c6dbbc3ab -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/paprefs/commit/9928ba44de326c9bb8be3e14aed56b4c6dbbc3ab You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gitlab-mirror at kemper.freedesktop.org Fri Jan 11 19:42:04 2019 From: gitlab-mirror at kemper.freedesktop.org (GitLab Mirror) Date: Fri, 11 Jan 2019 19:42:04 +0000 (UTC) Subject: [pulseaudio-commits] 6 commits - doc/README.html.in Message-ID: <20190111194204.8451B76147@kemper.freedesktop.org> doc/README.html.in | 54 ++++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 15 deletions(-) New commits: commit 34cd046afd9e9d286fe1ed54e66eca167e13a04e Author: Tanu Kaskinen Date: Fri Jan 11 17:23:08 2019 +0200 README: add a news item for the upcoming release diff --git a/doc/README.html.in b/doc/README.html.in index 77ee7f6..bc061f4 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -37,6 +37,32 @@ General Public License for more details.

News

+
Soon:
+

+Version 4.0 released. +Changes:

+ +
Tue Mar 24 2015:

Version 3.0 released; improved error handling; remember device selection visibility; window sizing improvements.

commit 180608cafc7fed5b319ece6f4a201bf7abb98e0b Author: Tanu Kaskinen Date: Fri Jan 11 16:40:00 2019 +0200 README: remove the page footer Keeping the footer up to date is extra work with little benefit. diff --git a/doc/README.html.in b/doc/README.html.in index 0698adf..77ee7f6 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -159,8 +159,5 @@ compilation and make install (as root) for installation of

If you have patches for pavucontrol, the primary method for submitting them is by creating a merge request in GitLab. Alternatively, you can send patches to the PulseAudio mailing list (requires subscription).

-
-
Lennart Poettering <@PACKAGE_BUGREPORT@>, October 2009
- commit 84ca4f3655f7fee95a1f915f200b868a7a21493d Author: Tanu Kaskinen Date: Fri Jan 11 16:35:54 2019 +0200 README: remove reference to an ancient Debian version It's of little use to know that the initial version was written on an April 2006 version of Debian testing. diff --git a/doc/README.html.in b/doc/README.html.in index 295bf7c..0698adf 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -124,12 +124,8 @@ playback stream separately.

Requirements

-

Currently, pavucontrol is tested on Linux only.

- -

pavucontrol was developed and tested on Debian GNU/Linux -"testing" from April 2006, it should work on most other Linux -distributions (and maybe Unix versions) since it uses GNU autoconf for -source code configuration.

+

Currently, pavucontrol is tested on Linux only. It should work on +most Linux distributions.

pavucontrol requires gtkmm and glademmm installed.

commit 4d4dcf6a0e21db1c8946e50dd70733351269097e Author: Tanu Kaskinen Date: Fri Jan 11 16:32:52 2019 +0200 README: remove the "Acknowledgements" section Acknowledging people's contributions is nice, but I don't like the chore of keeping the section up to date. diff --git a/doc/README.html.in b/doc/README.html.in index 71b4e48..295bf7c 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -18,7 +18,6 @@
  • Documentation
  • Requirements
  • Installation
  • -
  • Acknowledgements
  • Download
  • Bug Reports
  • Contributing Code
  • @@ -144,10 +143,6 @@ the source tree. After that you should run make for compilation and make install (as root) for installation of pavucontrol.

    -

    Acknowledgements

    - -

    Colin Guthrie for the card profile UI and other work

    -

    Download

    The newest release is always available from @PACKAGE_URL@

    commit 6791be3f0f77f1485ba2a9ebea277e749af91da4 Author: Tanu Kaskinen Date: Fri Jan 11 16:31:35 2019 +0200 README: add "Bug Reports" and "Contributing Code" sections diff --git a/doc/README.html.in b/doc/README.html.in index fdd001c..71b4e48 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -20,6 +20,8 @@
  • Installation
  • Acknowledgements
  • Download
  • +
  • Bug Reports
  • +
  • Contributing Code
  • License

    @@ -156,6 +158,16 @@ compilation and make install (as root) for installation of
    git clone https://gitlab.freedesktop.org/pulseaudio/pavucontrol.git
    +

    Bug Reports

    + +

    Here's the list of open bug reports: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/issues

    + +

    And here you can create a new bug report: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/issues/new

    + +

    Contributing Code

    + +

    If you have patches for pavucontrol, the primary method for submitting them is by creating a merge request in GitLab. Alternatively, you can send patches to the PulseAudio mailing list (requires subscription).

    +
    Lennart Poettering <@PACKAGE_BUGREPORT@>, October 2009
    commit f14cfbae5f9b6b33ddb79dc19c65cbfbae072a92 Author: Tanu Kaskinen Date: Fri Jan 11 16:21:31 2019 +0200 README: remove the copyright notice The copyright notice would need updating, because there are also others than Lennart and Colin who own copyrights to paprefs, and the years are out of date. Having to continuously update the copyright years seems just unnecessary churn to me. People can browse the git history if they're interested in the copyright details. diff --git a/doc/README.html.in b/doc/README.html.in index ea64a47..fdd001c 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -10,8 +10,6 @@

    PulseAudio Volume Control @PACKAGE_VERSION@

    -

    Copyright 2006-2009 Lennart Poettering, 2009-2011 Colin Guthrie <@PACKAGE_BUGREPORT@>

    -
    • License
    • News
    • From gitlab at gitlab.freedesktop.org Fri Jan 11 19:42:04 2019 From: gitlab at gitlab.freedesktop.org (Arun Raghavan) Date: Fri, 11 Jan 2019 19:42:04 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/pavucontrol][master] 6 commits: README: remove the copyright notice Message-ID: <5c38f18c6a10e_23e3fe7205551a81016512@gitlab-prod-gitlab-7f59448db7-6p2gh.mail> Arun Raghavan pushed to branch master at PulseAudio / pavucontrol Commits: f14cfbae by Tanu Kaskinen at 2019-01-11T14:21:31Z README: remove the copyright notice The copyright notice would need updating, because there are also others than Lennart and Colin who own copyrights to paprefs, and the years are out of date. Having to continuously update the copyright years seems just unnecessary churn to me. People can browse the git history if they're interested in the copyright details. - - - - - 6791be3f by Tanu Kaskinen at 2019-01-11T14:31:35Z README: add "Bug Reports" and "Contributing Code" sections - - - - - 4d4dcf6a by Tanu Kaskinen at 2019-01-11T14:32:52Z README: remove the "Acknowledgements" section Acknowledging people's contributions is nice, but I don't like the chore of keeping the section up to date. - - - - - 84ca4f36 by Tanu Kaskinen at 2019-01-11T14:35:54Z README: remove reference to an ancient Debian version It's of little use to know that the initial version was written on an April 2006 version of Debian testing. - - - - - 180608ca by Tanu Kaskinen at 2019-01-11T14:40:00Z README: remove the page footer Keeping the footer up to date is extra work with little benefit. - - - - - 34cd046a by Tanu Kaskinen at 2019-01-11T15:23:08Z README: add a news item for the upcoming release - - - - - 1 changed file: - doc/README.html.in Changes: ===================================== doc/README.html.in ===================================== @@ -10,8 +10,6 @@

      PulseAudio Volume Control @PACKAGE_VERSION@

      -

      Copyright 2006-2009 Lennart Poettering, 2009-2011 Colin Guthrie <@PACKAGE_BUGREPORT@>

      -

      License

      @@ -38,6 +37,32 @@ General Public License for more details.

      News

      +
      Soon:
      +

      +Version 4.0 released. +Changes:

      +
        +
      • There can now be only one pavucontrol window open at a time. Trying to +start pavucontrol for a second time brings the first window to foreground.
      • +
      • Added a "Show volume meters" checkbox to the Configuration tab. Disabling +the volume meters reduces CPU use.
      • +
      • Improve the use of space (remove useless margins and paddings).
      • +
      • Use a more appropriate icon for the channel lock button.
      • +
      • Maximum latency offset increased from 2 to 5 seconds to accommodate AirPlay +devices that often have higher latency than 2 seconds (this is not that useful +on newer PulseAudio versions, though, because the latency is reported much more +accurately than before).
      • +
      • New --version command line option.
      • +
      • New translations: Croatian, Korean, Norwegian Nynorsk, Lithuanian, +Valencian.
      • +
      • Updated translations: Chinese (Taiwan), Finnish, French, German, Italian, +Japanese, Polish, Swedish. +
      • +
      • Dropped support for Gtk+ 2.
      • +
      • Bumped the minimum supported libpulse version to 5.0.
      • +
      • Improved compatibility with newer Glade versions.
      • +
      +
      Tue Mar 24 2015:

      Version 3.0 released; improved error handling; remember device selection visibility; window sizing improvements.

      @@ -125,12 +150,8 @@ playback stream separately.

      Requirements

      -

      Currently, pavucontrol is tested on Linux only.

      - -

      pavucontrol was developed and tested on Debian GNU/Linux -"testing" from April 2006, it should work on most other Linux -distributions (and maybe Unix versions) since it uses GNU autoconf for -source code configuration.

      +

      Currently, pavucontrol is tested on Linux only. It should work on +most Linux distributions.

      pavucontrol requires gtkmm and glademmm installed.

      @@ -144,10 +165,6 @@ the source tree. After that you should run make for compilation and make install (as root) for installation of pavucontrol.

      -

      Acknowledgements

      - -

      Colin Guthrie for the card profile UI and other work

      -

      Download

      The newest release is always available from @PACKAGE_URL@

      @@ -158,8 +175,15 @@ compilation and make install (as root) for installation of
      git clone https://gitlab.freedesktop.org/pulseaudio/pavucontrol.git
      -
      -
      Lennart Poettering <@PACKAGE_BUGREPORT@>, October 2009
      +

      Bug Reports

      + +

      Here's the list of open bug reports: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/issues

      + +

      And here you can create a new bug report: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/issues/new

      + +

      Contributing Code

      + +

      If you have patches for pavucontrol, the primary method for submitting them is by creating a merge request in GitLab. Alternatively, you can send patches to the PulseAudio mailing list (requires subscription).

      View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/compare/62673a0f8e2a125da6195b610785bc2f4b0a4320...34cd046afd9e9d286fe1ed54e66eca167e13a04e -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/compare/62673a0f8e2a125da6195b610785bc2f4b0a4320...34cd046afd9e9d286fe1ed54e66eca167e13a04e You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gitlab at gitlab.freedesktop.org Mon Jan 14 07:10:41 2019 From: gitlab at gitlab.freedesktop.org (Tanu Kaskinen) Date: Mon, 14 Jan 2019 07:10:41 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] memblockq: fix typo: yepp -> yep Message-ID: <5c3c35f15aff8_23e3fe720699a2812790d9@gitlab-prod-gitlab-7f59448db7-6p2gh.mail> Tanu Kaskinen pushed to branch master at PulseAudio / pulseaudio Commits: 2e755f01 by Diego Viola at 2019-01-13T17:02:59Z memblockq: fix typo: yepp -> yep - - - - - 1 changed file: - src/pulsecore/memblockq.h Changes: ===================================== src/pulsecore/memblockq.h ===================================== @@ -27,7 +27,7 @@ #include #include -/* A memblockq is a queue of pa_memchunks (yepp, the name is not +/* A memblockq is a queue of pa_memchunks (yep, the name is not * perfect). It is similar to the ring buffers used by most other * audio software. In contrast to a ring buffer this memblockq data * type doesn't need to copy any data around, it just maintains View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/2e755f012e31ac819a10cf2b042da1104d08478a -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/2e755f012e31ac819a10cf2b042da1104d08478a You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gitlab at gitlab.freedesktop.org Wed Jan 16 04:09:42 2019 From: gitlab at gitlab.freedesktop.org (Arun Raghavan) Date: Wed, 16 Jan 2019 04:09:42 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] 3 commits: build-sys: Add the ability to disable maintainer mode Message-ID: <5c3eae867abb5_23e3fe6fb5080e419005e3@gitlab-prod-gitlab-7f59448db7-6p2gh.mail> Arun Raghavan pushed to branch master at PulseAudio / pulseaudio Commits: 39bc380c by Arun Raghavan at 2019-01-16T04:09:24Z build-sys: Add the ability to disable maintainer mode This allows us to disable automatically updating build system files in case things change. This is desirable in the common case, but not necessarily for CI, where we want the ability to take a build directory as an artifact from one stage to the next (i.e. into a fresh checkout). - - - - - 24c389c8 by Arun Raghavan at 2019-01-16T04:09:24Z tests: Shorten how long daemon tests take to run We split out some of the check-daemon tests that take a long time to run, and also reduce how long we wait for the daemon to start up. This should make the CI process quicker. - - - - - 9e0aa31f by Arun Raghavan at 2019-01-16T04:09:24Z pactl: Fix some corner cases when setting sink formats Mostly deals with failure more gracefully, and NULL-initialises the format array for safety. - - - - - 5 changed files: - Makefile.am - configure.ac - src/Makefile.am - src/tests/test-daemon.sh - src/utils/pactl.c Changes: ===================================== Makefile.am ===================================== @@ -109,6 +109,9 @@ dist-hook: check-daemon: $(MAKE) -C src check-daemon +check-daemon-long: + $(MAKE) -C src check-daemon-long + .PHONY: homepage distcleancheck doxygen # see git-version-gen ===================================== configure.ac ===================================== @@ -28,6 +28,8 @@ AC_CONFIG_HEADERS([config.h]) AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE([foreign 1.11 -Wall -Wno-portability subdir-objects silent-rules color-tests dist-xz tar-ustar]) +AM_MAINTAINER_MODE([enable]) + AS_IF([! test -n "$VERSION"], [ AC_MSG_ERROR([git-version-gen failed]) ]) ===================================== src/Makefile.am ===================================== @@ -297,12 +297,15 @@ TESTS_norun = \ # These tests need a running pulseaudio daemon TESTS_daemon = \ - connect-stress \ extended-test \ passthrough-test \ - interpol-test \ sync-playback +# These tests need a running daemon and take a while to complete +TESTS_daemon_long = \ + connect-stress \ + interpol-test + if !OS_IS_WIN32 TESTS_default += \ sigbus-test \ @@ -348,7 +351,7 @@ TESTS_ENVIRONMENT=MAKE_CHECK=1 TESTS = $(TESTS_default) if BUILD_TESTS_DEFAULT -noinst_PROGRAMS = $(TESTS_default) $(TESTS_norun) $(TESTS_daemon) +noinst_PROGRAMS = $(TESTS_default) $(TESTS_norun) $(TESTS_daemon) $(TESTS_daemon_long) else check_PROGRAMS = $(TESTS_default) $(TESTS_norun) endif @@ -356,6 +359,9 @@ endif check-daemon: $(TESTS_daemon) PATH=$(builddir):${PATH} $(top_srcdir)/src/tests/test-daemon.sh $(TESTS_daemon) +check-daemon-long: $(TESTS_daemon_long) + PATH=$(builddir):${PATH} $(top_srcdir)/src/tests/test-daemon.sh $(TESTS_daemon_long) + else TESTS_ENVIRONMENT= TESTS = @@ -367,6 +373,8 @@ check-daemon: @echo "Pass option \"--enable-tests\" to configure and install \"check\" library properly!" false +check-daemon-long: check-daemon + endif core_util_test_SOURCES = tests/core-util-test.c ===================================== src/tests/test-daemon.sh ===================================== @@ -48,7 +48,7 @@ pulseaudio -n \ & # wait a few seconds to let the daemon start! -sleep 5 +sleep 2 unset DISPLAY ===================================== src/utils/pactl.c ===================================== @@ -1045,7 +1045,7 @@ static void source_output_toggle_mute_callback(pa_context *c, const pa_source_ou #define MAX_FORMATS 256 static void set_sink_formats(pa_context *c, uint32_t sink, const char *str) { - pa_format_info *f_arr[MAX_FORMATS]; + pa_format_info *f_arr[MAX_FORMATS] = { 0, }; char *format = NULL; const char *state = NULL; int i = 0; @@ -1072,13 +1072,13 @@ static void set_sink_formats(pa_context *c, uint32_t sink, const char *str) { done: if (format) pa_xfree(format); - while(i--) + while (f_arr[i] && i--) pa_format_info_free(f_arr[i]); return; error: - while(i--) + while (f_arr[i] && i--) pa_format_info_free(f_arr[i]); quit(1); goto done; View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/compare/2e755f012e31ac819a10cf2b042da1104d08478a...9e0aa31f0a0d0c29ed0108dc1d6fa9e4d557b90f -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/compare/2e755f012e31ac819a10cf2b042da1104d08478a...9e0aa31f0a0d0c29ed0108dc1d6fa9e4d557b90f You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gitlab at gitlab.freedesktop.org Thu Jan 17 13:53:55 2019 From: gitlab at gitlab.freedesktop.org (Arun Raghavan) Date: Thu, 17 Jan 2019 13:53:55 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] bluez5-device: use correct RTP payload type Message-ID: <5c4088f3c9932_2413f9355cae6a833534d@gitlab-prod-gitlab-9cf5f998-vx4f9.mail> Arun Raghavan pushed to branch master at PulseAudio / pulseaudio Commits: ff17374f by Tanu Kaskinen at 2019-01-17T12:43:39Z bluez5-device: use correct RTP payload type If one device tries to use PulseAudio to send audio over A2DP to another device with bluez-alsa, that doesn't work because PulseAudio uses an incorrect RTP payload type and bluez-alsa checks that the RTP payload type is correct. According to the A2DP spec, the payload type should be set to a number between 96 and 127. Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/591 - - - - - 1 changed file: - src/modules/bluetooth/module-bluez5-device.c Changes: ===================================== src/modules/bluetooth/module-bluez5-device.c ===================================== @@ -505,7 +505,12 @@ static int a2dp_process_render(struct userdata *u) { /* write it to the fifo */ memset(sbc_info->buffer, 0, sizeof(*header) + sizeof(*payload)); header->v = 2; - header->pt = 1; + + /* A2DP spec: "A payload type in the RTP dynamic range shall be chosen". + * RFC3551 defines the dynamic range to span from 96 to 127, and 96 appears + * to be the most common choice in A2DP implementations. */ + header->pt = 96; + header->sequence_number = htons(sbc_info->seq_num++); header->timestamp = htonl(u->write_index / pa_frame_size(&u->sample_spec)); header->ssrc = htonl(1); View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/ff17374ffa9a8011236a5f7e0db74fddccbd19dc -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/ff17374ffa9a8011236a5f7e0db74fddccbd19dc You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gitlab at gitlab.freedesktop.org Fri Jan 18 16:39:49 2019 From: gitlab at gitlab.freedesktop.org (Tanu Kaskinen) Date: Fri, 18 Jan 2019 16:39:49 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] protocol-native: Fix format ownership while creating record streams Message-ID: <5c420155a7b19_2413f9321cda534867057@gitlab-prod-gitlab-9cf5f998-vx4f9.mail> Tanu Kaskinen pushed to branch master at PulseAudio / pulseaudio Commits: a5f25af0 by Arun Raghavan at 2019-01-18T16:34:33Z protocol-native: Fix format ownership while creating record streams - - - - - 1 changed file: - src/pulsecore/protocol-native.c Changes: ===================================== src/pulsecore/protocol-native.c ===================================== @@ -516,6 +516,9 @@ static record_stream* record_stream_new( pa_sink_input *direct_on_input, int *ret) { + /* Note: This function takes ownership of the 'formats' param, so we need + * to take extra care to not leak it */ + record_stream *s; pa_source_output *source_output = NULL; pa_source_output_new_data data; @@ -2368,6 +2371,8 @@ static void command_create_record_stream(pa_pdispatch *pd, uint32_t command, uin (passthrough ? PA_SOURCE_OUTPUT_PASSTHROUGH : 0); s = record_stream_new(c, source, &ss, &map, formats, &attr, volume_set ? &volume : NULL, muted, muted_set, flags, p, adjust_latency, early_requests, relative_volume, peak_detect, direct_on_input, &ret); + /* We no longer own the formats idxset */ + formats = NULL; CHECK_VALIDITY_GOTO(c->pstream, s, tag, ret, finish); View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/a5f25af0434bd703c502c230f5a5ff0238b6b8a3 -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/a5f25af0434bd703c502c230f5a5ff0238b6b8a3 You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gitlab at gitlab.freedesktop.org Wed Jan 23 15:29:34 2019 From: gitlab at gitlab.freedesktop.org (Tanu Kaskinen) Date: Wed, 23 Jan 2019 15:29:34 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] card: Only fire the profile available changed hook for linked cards Message-ID: <5c48885e83dac_2413f927286056c239058a@gitlab-prod-gitlab-9cf5f998-vx4f9.mail> Tanu Kaskinen pushed to branch master at PulseAudio / pulseaudio Commits: 334ae350 by João Paulo Rechi Vita at 2019-01-23T15:18:22Z card: Only fire the profile available changed hook for linked cards pa_card_profile_set_available needs to check if the card is linked before firing PA_CORE_HOOK_CARD_PROFILE_AVAILABLE_CHANGED, so callbacks connected to it receive a fully initialized card object. This fixes a crash introduced by commit 30a551bbc "switch-on-port-available: Check if we need to change the active profile". - - - - - 1 changed file: - src/pulsecore/card.c Changes: ===================================== src/pulsecore/card.c ===================================== @@ -89,7 +89,8 @@ void pa_card_profile_set_available(pa_card_profile *c, pa_available_t available) pa_assert_se(core = c->card->core); pa_subscription_post(core, PA_SUBSCRIPTION_EVENT_CARD|PA_SUBSCRIPTION_EVENT_CHANGE, c->card->index); - pa_hook_fire(&core->hooks[PA_CORE_HOOK_CARD_PROFILE_AVAILABLE_CHANGED], c); + if (c->card->linked) + pa_hook_fire(&core->hooks[PA_CORE_HOOK_CARD_PROFILE_AVAILABLE_CHANGED], c); } pa_card_new_data* pa_card_new_data_init(pa_card_new_data *data) { View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/334ae350b4cdd8af2d6d3b4034f58fa0b3ad7f53 -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/334ae350b4cdd8af2d6d3b4034f58fa0b3ad7f53 You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gitlab at gitlab.freedesktop.org Fri Jan 25 07:32:58 2019 From: gitlab at gitlab.freedesktop.org (Tanu Kaskinen) Date: Fri, 25 Jan 2019 07:32:58 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/paprefs][master] prepare for releasing 1.1 Message-ID: <5c4abbaa9bb8a_24d3f881d2611c0250489@gitlab-prod-gitlab-586fbf4996-nfghf.mail> Tanu Kaskinen pushed to branch master at PulseAudio / paprefs Commits: f63c50b1 by Tanu Kaskinen at 2019-01-25T07:18:10Z prepare for releasing 1.1 - - - - - 2 changed files: - doc/README.html.in - meson.build Changes: ===================================== doc/README.html.in ===================================== @@ -37,7 +37,7 @@ General Public License for more details.

      News

      -
      Soon:

      Fri Jan 25 2019:

      Version 1.1 released; replace dbus-glib and libdbus with gdbus, use module-combine-sink instead of module-combine

      ===================================== meson.build ===================================== @@ -1,6 +1,6 @@ project('paprefs', 'cpp', license: 'GPL2+', - version: '1.0', + version: '1.1', meson_version: '>=0.40.1' ) View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/paprefs/commit/f63c50b177cf275cc79fc5245e8a8b601b21bd1f -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/paprefs/commit/f63c50b177cf275cc79fc5245e8a8b601b21bd1f You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gitlab at gitlab.freedesktop.org Fri Jan 25 07:33:11 2019 From: gitlab at gitlab.freedesktop.org (Tanu Kaskinen) Date: Fri, 25 Jan 2019 07:33:11 +0000 Subject: [pulseaudio-commits] [Git][pulseaudio/paprefs] Pushed new tag v1.1 Message-ID: <5c4abbb786609_24d3f881d26106c250692@gitlab-prod-gitlab-586fbf4996-nfghf.mail> Tanu Kaskinen pushed new tag v1.1 at PulseAudio / paprefs -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/paprefs/tree/v1.1 You're receiving this email because of your account on gitlab.freedesktop.org. -------------- next part -------------- An HTML attachment was scrubbed... URL: