[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] start-pulseaudio-x11: Make 'plasma' version check shell portable

[Tanu Kaskinen]

Tanu Kaskinen pushed to branch master at PulseAudio / pulseaudio


Commits:
28347d06 by Vasilis Tsiligiannis at 2019-11-18T14:27:03Z
start-pulseaudio-x11: Make 'plasma' version check shell portable

Currently, the version check snippet uses a 'bash' extension which
arithemtically evaluates variables prior to expansion. This approach
does not nesseceraly work on other shells which may complain with
'5: Illegal numer' error. Expand the arithmetic expression before
evaluation to avoid such an error.

Signed-off-by: Vasilis Tsiligiannis <acinonyx at openwrt.gr>

- - - - -


1 changed file:

- src/daemon/start-pulseaudio-x11.in


Changes:

=====================================
src/daemon/start-pulseaudio-x11.in
=====================================
@@ -26,7 +26,7 @@ if [ x"$DISPLAY" != x ] ; then
     # Check for current plasma version and load module if it's necessary.
     if [ x"$KDE_FULL_SESSION" = x"true" ]; then
         plasmaversion="$(plasmashell -v 2>/dev/null | sed -n 's/^plasmashell \([0-9][0-9]*\)\.\([0-9][0-9]*\)\.\([0-9][0-9]*\)/\1*1000000+\2*1000+\3/p' | head -1)"
-        if [ -n "$plasmaversion" ] && [ "$((plasmaversion))" -lt "5017000" ]; then
+        if [ -n "$plasmaversion" ] && [ "$(($plasmaversion))" -lt "5017000" ]; then
             @PACTL_BINARY@ load-module module-device-manager "do_routing=1" > /dev/null
         fi
     fi



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/28347d0602045ea91475f55a7652bac8ef0ed1f8

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/28347d0602045ea91475f55a7652bac8ef0ed1f8
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20191121/8e66c19b/attachment.html>