[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] filter-apply: Look for filter parameters also in device properties

[PulseAudio Marge Bot]

PulseAudio Marge Bot pushed to branch master at PulseAudio / pulseaudio


Commits:
4552fe15 by Sebastian Krzyszkowiak at 2020-12-14T21:01:16+00:00
filter-apply: Look for filter parameters also in device properties

Some filters take parameters that effectively describe the hardware
they're being applied to (like echo-cancel allowing to specify the
mic array parameters for better noise filtering). This allows system
integrators to set default parameters for such modules per-device,
which will get used when the stream doesn't specify their own.

Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/400>

- - - - -


1 changed file:

- src/modules/module-filter-apply.c


Changes:

=====================================
src/modules/module-filter-apply.c
=====================================
@@ -146,15 +146,20 @@ static const char* get_filter_name(pa_object *o, bool is_sink_input) {
 static const char* get_filter_parameters(pa_object *o, const char *want, bool is_sink_input) {
     const char *parameters;
     char *prop_parameters;
-    pa_proplist *pl;
+    pa_proplist *pl, *device_pl;
 
-    if (is_sink_input)
+    if (is_sink_input) {
         pl = PA_SINK_INPUT(o)->proplist;
-    else
+        device_pl = PA_SINK_INPUT(o)->sink->proplist;
+    } else {
         pl = PA_SOURCE_OUTPUT(o)->proplist;
+        device_pl = PA_SOURCE_OUTPUT(o)->source->proplist;
+    }
 
     prop_parameters = pa_sprintf_malloc(PA_PROP_FILTER_APPLY_PARAMETERS, want);
     parameters = pa_proplist_gets(pl, prop_parameters);
+    if (!parameters)
+        parameters = pa_proplist_gets(device_pl, prop_parameters);
     pa_xfree(prop_parameters);
 
     return parameters;



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/4552fe15b3578219d7e21cb77018a5f9425cd593

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/4552fe15b3578219d7e21cb77018a5f9425cd593
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20201214/3293c490/attachment-0001.htm>