[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] virtual-surround-sink: Use correct sample spec with memblockq

[Georg Chini]

Georg Chini pushed to branch master at PulseAudio / pulseaudio


Commits:
f5d3606f by Tanu Kaskinen at 2020-01-05T09:31:07+02:00
virtual-surround-sink: Use correct sample spec with memblockq

The memblockq stores data in the virtual sink format, not in the master
sink format. The wrong sample spec caused a crash when the virtual sink
rendered data whose length was not divisible by the sink input frame
size.

Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/786

- - - - -


1 changed file:

- src/modules/module-virtual-surround-sink.c


Changes:

=====================================
src/modules/module-virtual-surround-sink.c
=====================================
@@ -786,7 +786,7 @@ int pa__init(pa_module*m) {
     u->sink->input_to_master = u->sink_input;
 
     pa_sink_input_get_silence(u->sink_input, &silence);
-    u->memblockq = pa_memblockq_new("module-virtual-surround-sink memblockq", 0, MEMBLOCKQ_MAXLENGTH, 0, &sink_input_ss, 1, 1, 0, &silence);
+    u->memblockq = pa_memblockq_new("module-virtual-surround-sink memblockq", 0, MEMBLOCKQ_MAXLENGTH, 0, &ss, 1, 1, 0, &silence);
     pa_memblock_unref(silence.memblock);
 
     /* resample hrir */



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/f5d3606fe76302c7dbdb0f6a80400df829a5f846

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/f5d3606fe76302c7dbdb0f6a80400df829a5f846
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20200105/e4985fd6/attachment.htm>