[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] ucm: Don't log errors during normal operation

[Tanu Kaskinen]

Tanu Kaskinen pushed to branch master at PulseAudio / pulseaudio


Commits:
9d36210b by Tanu Kaskinen at 2020-03-17T09:31:38+02:00
ucm: Don't log errors during normal operation

It's completely normal to not have explicit channel configuration for
stereo devices. In fact, the ALSA developers actively avoid configuring
the channels for stereo devices.

I also dropped the word "duplex" from the messages, because "stereo
duplex" implies bidirectionality, but most devices use one direction
only.

- - - - -


1 changed file:

- src/modules/alsa/alsa-ucm.c


Changes:

=====================================
src/modules/alsa/alsa-ucm.c
=====================================
@@ -379,8 +379,8 @@ static int ucm_get_device_property(
 
     if (pa_proplist_gets(device->proplist, PA_ALSA_PROP_UCM_SINK) &&
         device->playback_channels == 0) {
-        pa_log("UCM file does not specify 'PlaybackChannels' "
-                    "for device %s, assuming stereo duplex.", device_name);
+        pa_log_info("UCM file does not specify 'PlaybackChannels' "
+                    "for device %s, assuming stereo.", device_name);
         device->playback_channels = 2;
     }
 
@@ -400,8 +400,8 @@ static int ucm_get_device_property(
 
     if (pa_proplist_gets(device->proplist, PA_ALSA_PROP_UCM_SOURCE) &&
         device->capture_channels == 0) {
-        pa_log("UCM file does not specify 'CaptureChannels' "
-                    "for device %s, assuming stereo duplex.", device_name);
+        pa_log_info("UCM file does not specify 'CaptureChannels' "
+                    "for device %s, assuming stereo.", device_name);
         device->capture_channels = 2;
     }
 



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/9d36210beca09cc7a3841d09e5246d4b0000c52d

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/9d36210beca09cc7a3841d09e5246d4b0000c52d
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20200317/14e93ae8/attachment.htm>