[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] parecord: really fix recording OGG

[PulseAudio Marge Bot]

PulseAudio Marge Bot pushed to branch master at PulseAudio / pulseaudio


Commits:
1a73fb9e by Martin Wilck at 2021-04-19T18:24:34+02:00
parecord: really fix recording OGG

432a91ed ("fix "Failed to open audio file" for FLAC and OGG)" claimed
to fix recording of OGG files with pacat, but it really fixed only
FLAC. This patch must be added on top to fix OGG, too.

Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/542>

- - - - -


1 changed file:

- src/utils/pacat.c


Changes:

=====================================
src/utils/pacat.c
=====================================
@@ -1067,9 +1067,12 @@ int main(int argc, char *argv[]) {
 	     * Endianness has been set in pa_sndfile_write_sample_spec(), but
 	     * libsndfile errors out if endianness is set to anything other than
 	     * SF_ENDIAN_FILE for OGG or FLAC. Clear it.
+	     * For OGG, libsndfile accepts only subformat SF_FORMAT_VORBIS.
 	     */
 	    if (file_format == SF_FORMAT_OGG || file_format == SF_FORMAT_FLAC)
 		    sfi.format = (sfi.format & ~SF_FORMAT_ENDMASK) | SF_ENDIAN_FILE;
+	    if (file_format == SF_FORMAT_OGG)
+		    sfi.format = (sfi.format & ~SF_FORMAT_SUBMASK) | SF_FORMAT_VORBIS;
 
         }
 



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/1a73fb9eb9851d00e2907a3dbd50d8dfb5e173b2

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/1a73fb9eb9851d00e2907a3dbd50d8dfb5e173b2
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20210419/3b835875/attachment.htm>