[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] shell-completion: bash: Localize word variable

PulseAudio Marge Bot (@pulseaudio-merge-bot) gitlab at gitlab.freedesktop.org
Wed Aug 25 16:03:33 UTC 2021



PulseAudio Marge Bot pushed to branch master at PulseAudio / pulseaudio


Commits:
53e3b534 by Sibo Dong at 2021-08-25T15:54:35+00:00
shell-completion: bash: Localize word variable

The word variables used in the _pactl and _pacmd functions are
unlocalized. Thus, the variable appears in the user's environment when
tab-completing with pactl or pacmd. This may clobber another variable
of the same name, which is undesirable.

Localize the word variable to fix this issue.

Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/623>

- - - - -


1 changed file:

- shell-completion/bash/pulseaudio


Changes:

=====================================
shell-completion/bash/pulseaudio
=====================================
@@ -109,7 +109,7 @@ in_array() {
 }
 
 _pactl() {
-    local cur prev words cword preprev command
+    local cur prev words cword preprev word command
     local comps
     local flags='-h --help --version -s --server= --client-name='
     local list_types='short sinks sources sink-inputs source-outputs cards
@@ -255,7 +255,7 @@ _pactl() {
 complete -F _pactl pactl
 
 _pacmd() {
-    local cur prev words cword preprev command
+    local cur prev words cword preprev word command
     local comps
     local flags='-h --help --version'
     local commands=(exit help list-modules list-cards list-sinks list-sources list-clients



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/53e3b534086d34d9077b581b8bbf38d3260b813c

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/53e3b534086d34d9077b581b8bbf38d3260b813c
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20210825/3dc32632/attachment-0001.htm>


More information about the pulseaudio-commits mailing list