[pulseaudio-commits] [Git][pulseaudio/pavucontrol][master] card: do not quit on error sending message to object

[PulseAudio Marge Bot]

PulseAudio Marge Bot pushed to branch master at PulseAudio / pavucontrol


Commits:
15154921 by Igor V. Kovalenko at 2021-02-27T15:13:13+03:00
card: do not quit on error sending message to object

Server API versions < 35 do not support PA_COMMAND_SEND_OBJECT_MESSAGE
one of these is current Pipewire pulseaudio server.

Do not quit on error sending message to object, this is already handled as if
send message API is not available.

Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/57>

- - - - -


2 changed files:

- src/cardwidget.cc
- src/pavucontrol.cc


Changes:

=====================================
src/cardwidget.cc
=====================================
@@ -141,7 +141,7 @@ void CardWidget::onCodecChange() {
 
           if (!(o = pa_context_send_message_to_object(get_context(), card_bluez_message_handler_path(pulse_card_name).c_str(),
               "switch-codec", codec_message.c_str(), NULL, NULL))) {
-              show_error(_("pa_context_set_card_profile_by_index() failed"));
+              g_debug(_("pa_context_send_message_to_object() failed: %s"), pa_strerror(pa_context_errno(get_context())));
               return;
           }
 


=====================================
src/pavucontrol.cc
=====================================
@@ -155,7 +155,7 @@ template<typename U> void send_message(pa_context *c, const char *target, const
 
     if (!o) {
         delete send_message_userdata;
-        show_error(_("pa_context_send_message_to_object() failed"));
+        g_debug(_("pa_context_send_message_to_object() failed: %s"), pa_strerror(pa_context_errno(context)));
         return;
     }
     pa_operation_unref(o);



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/commit/1515492168edc2585768da0d733b85bc0dab5a07

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/commit/1515492168edc2585768da0d733b85bc0dab5a07
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20210227/85abb080/attachment.htm>