[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] bluetooth: ldac: Fix missing check for RTP LDAC payloader element

[PulseAudio Marge Bot (@pulseaudio-merge-bot)]

PulseAudio Marge Bot pushed to branch master at PulseAudio / pulseaudio


Commits:
8dbe5f7a by Sanchayan Maity at 2021-05-19T18:09:43+05:30
bluetooth: ldac: Fix missing check for RTP LDAC payloader element

While at it, improve the error message to include the name of the
element which was not found.

Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/560>

- - - - -


1 changed file:

- src/modules/bluetooth/a2dp-codec-ldac-gst.c


Changes:

=====================================
src/modules/bluetooth/a2dp-codec-ldac-gst.c
=====================================
@@ -41,10 +41,16 @@ static bool can_be_supported(bool for_encoding) {
 
     element_factory = gst_element_factory_find("ldacenc");
     if (element_factory == NULL) {
-        pa_log_info("LDAC encoder not found");
+        pa_log_info("LDAC encoder element `ldacenc` not found");
         return false;
     }
+    gst_object_unref(element_factory);
 
+    element_factory = gst_element_factory_find("rtpldacpay");
+    if (element_factory == NULL) {
+        pa_log_info("LDAC RTP payloader element `rtpldacpay` not found");
+        return false;
+    }
     gst_object_unref(element_factory);
 
     return true;



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/8dbe5f7ad45541a138e35289923aaee8d3c164d3

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/8dbe5f7ad45541a138e35289923aaee8d3c164d3
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20210519/27d28b95/attachment.htm>