[pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] Propagate return value from pa_pstream_attach_memfd_shmid

[PulseAudio Marge Bot (@pulseaudio-merge-bot)]

PulseAudio Marge Bot pushed to branch master at PulseAudio / pulseaudio


Commits:
3f945541 by Alistair Leslie-Hughes at 2022-10-19T08:06:46+11:00
Propagate return value from pa_pstream_attach_memfd_shmid

Using wine,
The mmap call in shm_attach sometimes fails with ENOMEM which isn't propagated
up the call stack.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/747>

- - - - -


1 changed file:

- src/pulsecore/native-common.c


Changes:

=====================================
src/pulsecore/native-common.c
=====================================
@@ -64,7 +64,8 @@ int pa_common_command_register_memfd_shmid(pa_pstream *p, pa_pdispatch *pd, uint
     if (version < 31 || pa_tagstruct_getu32(t, &shm_id) < 0 || !pa_tagstruct_eof(t))
         goto finish;
 
-    pa_pstream_attach_memfd_shmid(p, shm_id, ancil->fds[0]);
+    if (pa_pstream_attach_memfd_shmid(p, shm_id, ancil->fds[0]))
+        goto finish;
 
     ret = 0;
 finish:



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/3f9455411c90d2b2d1043c47ee24185fabb8e401

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/3f9455411c90d2b2d1043c47ee24185fabb8e401
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20221028/c737295c/attachment.htm>