[Git][pulseaudio/pulseaudio][master] rtp-recv: Remove inappropriate byte order conversion

[PulseAudio Marge Bot (@pulseaudio-merge-bot)]

PulseAudio Marge Bot pushed to branch master at PulseAudio / pulseaudio


Commits:
8ef0d597 by bert at 2024-08-21T13:22:14+00:00
rtp-recv: Remove inappropriate byte order conversion

Conversion of the `service` argument of `getaddrinfo()` to big-endian
byte order causes module-rtp-recv to bind to an incorrect port (37670)
for SAP announcements on little-endian architectures

Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/828>

- - - - -


1 changed file:

- src/modules/rtp/module-rtp-recv.c


Changes:

=====================================
src/modules/rtp/module-rtp-recv.c
=====================================
@@ -710,7 +710,7 @@ int pa__init(pa_module*m) {
 
         pa_zero(hints);
 
-        service = pa_sprintf_malloc("%d", htons(SAP_PORT));
+        service = pa_sprintf_malloc("%d", SAP_PORT);
 
         hints.ai_flags = AI_NUMERICHOST;
         if (getaddrinfo(sap_address, service, &hints, &sap_addrinfo) != 0) {



View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/8ef0d597a1561ee9988dc31f04925e4412d69957

-- 
View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/8ef0d597a1561ee9988dc31f04925e4412d69957
You're receiving this email because of your account on gitlab.freedesktop.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-commits/attachments/20240821/80273093/attachment.htm>